Bug 658586
| Summary: | GFS2: Verify that generic quota tools can perform all functions of gfs2_quota | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Abhijith Das <adas> | ||||||
| Component: | quota | Assignee: | Petr Pisar <ppisar> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Martin Cermak <mcermak> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 6.1 | CC: | agk, bmarzins, ccaulfie, cfeist, cluster-maint, fdinitto, fnadge, lhh, mcermak, ovasik, riek, rpeterso, ssaha, swhiteho, teigland | ||||||
| Target Milestone: | rc | Keywords: | FutureFeature, Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | quota-3.17-13.el6 | Doc Type: | Enhancement | ||||||
| Doc Text: |
Cause
Replace gfs2_quota utility specific to GFS2 with
generic quota utilities.
Consequence
quota utilities could not initialize, check, change,
and synchronize GFS2 quotas.
Change
Complete support for GFS2 quota metadata has been
implemented, new quotasync tool for explicit quota
synchronization has been provided.
Result
All standard quota operations can be performed with
quota tools on GFS2 file system. Users are encouraged
to use quota tools instead of specific gfs_quota tool.
|
Story Points: | --- | ||||||
| Clone Of: | 596794 | Environment: | |||||||
| Last Closed: | 2011-05-19 14:09:58 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 596794, 676843 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Comment 3
Sayan Saha
2010-12-01 22:22:19 UTC
Created attachment 476999 [details]
quotasync patch
Sync patch transposed from upstream.
Created attachment 477000 [details]
quotacheck patch
quotacheck patch implementing GFS2 transposed from upstream.
Many thanks for sorting this out. It will be really good to have these tools available for gfs2 in rhel6.1 Can you post the exact message that you got? Quota should be changeable via remount, they are not changeable via the quota call, but you can get the current status that way. kernel-2.6.32-112.el6.x86_64 util-linux-ng-2.17.2-9.el6.x86_64 gfs2-utils-3.0.12-33.el6.x86_64 # mount -o remount,quota=on /mnt/quota/ error mounting /dev/loop0 on /mnt/quota: Invalid argument # dmesg GFS2: invalid mount option: seclabel The same for remount,quota=off. /etc/fstab has no record for that mount point or block device. I have mounted /dev/loop0 backed by regular file. Interesting. It is true that seclabel is not a valid option - I guess it is some selinux thing. Can you try with selinux turned off? Permissive mode did not help. Disabling SELinux helped. That is a bit odd still, nobody has reported that issue before, so I'm not sure what is different in your case, but at least we know the answer now. Selinux is not supported on GFS2 in general. # strace -eexecve -s256 -fq mount -o remount,quota=on /mnt/quota/
execve("/bin/mount", ["mount", "-o", "remount,quota=on", "/mnt/quota/"], [/* 33 vars */]) = 0
[pid 1605] execve("/sbin/mount.gfs2", ["/sbin/mount.gfs2", "/dev/loop0", "/mnt/quota", "-o", "rw,remount,relatime,seclabel,localflocks,localcaching,quota=on,quota=on"], [/* 29 vars */]) = 0
error mounting /dev/loop0 on /mnt/quota: Invalid argument
The mount helper is being added some options by /bin/mount.
Which come from /proc/mounts obviously: /dev/loop0 /mnt/quota gfs2 rw,seclabel,relatime,localflocks,localcaching,quota=on 0 0 Ok, we'll have to look into that. Can you open a bz for that specifically? I suspect that we just need to make mount.gfs2 ignore the extra argument. It is annoying that every time we want to support an extra mount argument we have to update it. Note that mount.gfs2 will be gone in RHEL7 (it has just been removed from Fedora rawhide) which should resolve this problem. It shouldn't affect testing of this particular quota feature now we know what the problem is though, I think. Bug #676630 opened for the remount/seclabel issue. Verified according to https://beaker.engineering.redhat.com/jobs/62389. Hi, I am reviewing and editing erratum: http://errata.devel.redhat.com/errata/stateview/10703 and would need some more details for this bug to state all the necessary points. Could you give a few key words to the points I pasted into the Technical Notes field. Once I have the text I can start on the approval process. Thanks
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Cause
What actions or circumstances induced the feature request.
Consequence
What action was inhibited by the feature’s absence.
Change
What was done to implement the feature.
Note: backported from upstream is not an explanation.
Result
What now happens when the actions or circumstances above occur.
Note: this is not the same as the feature request was fulfilled.
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Diffed Contents:
@@ -1,10 +1,14 @@
Cause
- What actions or circumstances induced the feature request.
+ Replace gfs2_quota utility specific to GFS2 with
+ generic quota utilities.
Consequence
- What action was inhibited by the feature’s absence.
+ quota utilities could not initialize, check, change,
+ and synchronize GFS2 quotas.
Change
- What was done to implement the feature.
- Note: backported from upstream is not an explanation.
+ Complete support for GFS2 quota metadata has been
+ implemented, new quotasync tool for explicit quota
+ synchronization has been provided.
Result
- What now happens when the actions or circumstances above occur.
+ All standard quota operations can be performed with
- Note: this is not the same as the feature request was fulfilled.+ quota tools on GFS2 file system. Users are encouraged
+ to use quota tools instead of specific gfs_quota tool.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0716.html |