Bug 658794 - Configuration -> Download Diff does not work in Spacewalk
Summary: Configuration -> Download Diff does not work in Spacewalk
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: WebUI
Version: 1.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: Michael Mráka
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks: space16
TreeView+ depends on / blocked
 
Reported: 2010-12-01 10:25 UTC by Lukas Zapletal
Modified: 2011-08-19 14:39 UTC (History)
1 user (show)

Fixed In Version: spacewalk-java-1.5.48-1
Clone Of:
Environment:
Last Closed: 2011-08-19 14:39:34 UTC
Embargoed:

Attachments (Terms of Use)

Description Lukas Zapletal 2010-12-01 10:25:10 UTC 
Description of problem:

Download diff link throws ISE

ERROR org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/rhn].[action] - Servlet.service() for servlet action threw exception
java.lang.IllegalArgumentException: Could not find ACL handler file_is_directory in statement: "not file_is_directory()". Available ACL handlers: [can_access_channel, config_channel_editable, config_channel_has_files, config_channel_has_systems, config_channel_type, config_enabled, formvar_exists, is, is_file, is_protected, is_satellite, is_solaris, need_first_user, org_channel_family, org_entitlement, org_proxy_evr_at_least, org_role, probe_suite_access, system_feature, system_has_management_entitlement, system_has_virtualization_entitlement, system_is_in_ssm, trust_channel_access, uid_role, user_authenticated, user_can_manage_channels, user_role]
        at com.redhat.rhn.common.security.acl.Acl.evalAcl(Acl.java:454)
        at com.redhat.rhn.manager.acl.AclManager.hasAcl(AclManager.java:81)
        at com.redhat.rhn.manager.acl.AclManager.hasAcl(AclManager.java:49)
        at com.redhat.rhn.frontend.struts.RhnRequestProcessor.process(RhnRequestProcessor.java:71)
        at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196)
        at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414)
...


Version-Release number of selected component (if applicable):

Spacewalk master


Steps to Reproduce:
1. Create a config channel, a file, bump a version
2. Click on the Download Diff
  
Actual results:
ISE

Expected results:
A file download

Additional info:

Missing ACL function file_is_directory has been removed from the code.

Introduced by decfd969cd098c407fe2fc03f975fda7f46dfe00 (2010-08-17)
Comment 3 Miroslav Suchý 2011-04-11 07:31:41 UTC 
We did not have time for this one during Spacewalk 1.4 time frame. Mass moving to Spacewalk 1.5.
Comment 4 Miroslav Suchý 2011-04-11 07:36:29 UTC 
We did not have time for this one during Spacewalk 1.4 time frame. Mass moving to Spacewalk 1.5.
Comment 5 Jan Pazdziora (Red Hat) 2011-07-20 11:49:25 UTC 
Aligning under space16.
Comment 6 Michael Mráka 2011-08-19 14:39:34 UTC 
This issue has been fixed while working on bug 710959.

Spacewalk master commit is
commit 85c887985b1a43e78eddffe47bf06487da0b10b9
    710959 - rename acl: not file_is_directory -> is_file
    decfd969 removes aclFileIsDirecotry and introduces aclIsFile

Closing with CURRENTRELEASE, please reopen if the bug persists on your
Spacewalk 1.5+.
Note You need to log in before you can comment on or make changes to this bug.