Spec URL: http://asrob.fedorapeople.org/SOURCES/drupal6-schema.spec> SRPM URL: http://asrob.fedorapeople.org/SOURCES/drupal6-schema-1.7-1.fc14.src.rpm Description: Introduced in Drupal 6, the Schema API allows modules to declare their database tables in a structured array (similar to the Form API) and provides API functions for creating, dropping, and changing tables, columns, keys, and indexes. The Schema module provides additional Schema-related functionality not provided by the core Schema API that is useful for module developers. Currently, this includes: Schema documentation: hyperlinked display of the schema's embedded documentation explaining what each table and field is for. Schema structure generation: the module examines the live database and creates Schema API data structures for all tables that match the live database. Schema comparison: the module compares the live database structure with the schema structure declared by all enabled modules, reporting on any missing or incorrect tables. rpmlint output: [asrob@alice SPECS]$ rpmlint drupal6-schema.spec ../SRPMS/drupal6-schema-1.7-1.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2636751 Watching tasks (this may be safely interrupted)... 2636751 build (dist-f14, drupal6-schema-1.7-1.fc14.src.rpm): open (x86-16.phx2.fedoraproject.org) 2636752 buildArch (drupal6-schema-1.7-1.fc14.src.rpm, noarch): free 2636752 buildArch (drupal6-schema-1.7-1.fc14.src.rpm, noarch): free -> open (x86-07.phx2.fedoraproject.org) 2636752 buildArch (drupal6-schema-1.7-1.fc14.src.rpm, noarch): open (x86-07.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2636751 build (dist-f14, drupal6-schema-1.7-1.fc14.src.rpm): open (x86-16.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2636751 build (dist-f14, drupal6-schema-1.7-1.fc14.src.rpm) completed successfully
Just some comments: Please align the columns (Name, Group, License, ...). chmod and cp don't belong in the build section, but in prep. Don't delete the empty build section though. I already suggested at another review, rather to delete the text files than to exclude them. See https://bugzilla.redhat.com/show_bug.cgi?id=646611#c3 chmod and cp don't belong in the build section, but in prep. Don't delete the empty build section though. There are many more files that have executable permissions, but shouldn't. Also see the sub-directories! Please also take a look at "Kopie von schema.de.po", whether it's any use. Please try to get in contact with other Drupal module maintainers and decide on the version number style. CCK uses 6.x.2.8, while you are using 1.7. The license is stated nowhere in the code, and I also can't find it on the project's page. If you can't find out either, please clarify the license with the author and attach his statement as %doc. You may also consider to define another macro instead of drupaldir: %{_datadir}/drupal/modules/schema, because that's the only way you're using it. Please also try to clean up the description. Enter linebreaks between the paragraphs, if you think that the whole description is necessary and useful. Lines may be up to 80 characters long.
Your version numbering scheme is fine! Please correct the license to GPLv2+, as all modules hosted in Drupal's CVS must be.
http://asrob.fedorapeople.org/SOURCES/drupal6-schema.spec http://asrob.fedorapeople.org/SOURCES/drupal6-schema-1.7-2.fc14.src.rpm Fixed. rpmlint output: [asrob@alice SPECS]$ rpmlint drupal6-schema.spec ../SRPMS/drupal6-schema-1.7-2.fc14.src.rpm ../RPMS/noarch/drupal6-schema-1.7-2.fc14.noarch.rpm drupal6-schema.noarch: W: file-not-in-%lang /usr/share/drupal6/modules/schema/translations/de.mo drupal6-schema.noarch: W: file-not-in-%lang /usr/share/drupal6/modules/schema/translations/schema.de.mo drupal6-schema.noarch: W: file-not-in-%lang /usr/share/drupal6/modules/schema/translations/schema.mo 2 packages and 1 specfiles checked; 0 errors, 3 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2739121 Watching tasks (this may be safely interrupted)... 2739121 build (dist-f14, drupal6-schema-1.7-2.fc14.src.rpm): free 2739121 build (dist-f14, drupal6-schema-1.7-2.fc14.src.rpm): free -> open (x86-20.phx2.fedoraproject.org) 2739122 buildArch (drupal6-schema-1.7-2.fc14.src.rpm, noarch): free 2739122 buildArch (drupal6-schema-1.7-2.fc14.src.rpm, noarch): free -> open (x86-14.phx2.fedoraproject.org) 2739122 buildArch (drupal6-schema-1.7-2.fc14.src.rpm, noarch): open (x86-14.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2739121 build (dist-f14, drupal6-schema-1.7-2.fc14.src.rpm): open (x86-20.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2739121 build (dist-f14, drupal6-schema-1.7-2.fc14.src.rpm) completed successfully
http://asrob.fedorapeople.org/SOURCES/drupal6-schema.spec http://asrob.fedorapeople.org/SOURCES/drupal6-schema-1.7-4.fc14.src.rpm Updated files.