Created attachment 464306 [details]
patch to fix cups shutdown problem

Description of problem:

When rebooting or halting a system with the CUPS service running, the CUPS
service won't stop normally. Instead, it has to be killed in the final stage of reboot or shutdown. This is almost identical to bug 652786 except it's CUPS and not NFS.

Version-Release number of selected component (if applicable):

cups-1.4.4-11.fc14.i686

How reproducible:

Operate system normally with CUPS service running. 

Steps to Reproduce:
1. Have CUPS start either on runlevel or manual start
2. Reboot or halt system


Actual results:

CUPS fails to stop. The cupsd daemon has to be killed in the final moment before shutdown or reboot.

Expected results:

CUPS service stops normally without having to be killed outside its init script.

Additional info:

If CUPS is stopped manually before reboot/halt like so:

# service cups stop

it will stop cleanly and show appropriate messages for various components.
However, when the system is rebooting or halting no CUPS messages are seen,
seeming to indicate that it never shuts down.

The bug exists because the subsystem lock file name does not match
the init script name. The /etc/rc.d/rc script checks to see if a subsytem is
running by using the name of the init script for the subsystem file. In the
case of the CUPS subsystem, the CUPS init script creates a subsysetm file
/var/lock/subsys/cupsd. It should be cups (no d on the end).

A simple tweak to the init script fixes the problem. Patch attached.