Bug 659919 - include a transmission systemd unit file
Summary: include a transmission systemd unit file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: transmission
Version: rawhide
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-04 07:22 UTC by Rahul Sundaram
Modified: 2011-10-09 19:41 UTC (History)
7 users (show)

Fixed In Version: transmission-2.33-2.fc16
Clone Of:
Environment:
Last Closed: 2011-10-09 19:41:42 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
0001-add-systemd-file-659919.patch (6.84 KB, patch)
2011-09-10 12:01 UTC, Tomasz Torcz
no flags Details | Diff
0002-drop-sysconfig-file.patch (2.18 KB, patch)
2011-09-10 12:02 UTC, Tomasz Torcz
no flags Details | Diff

Description Rahul Sundaram 2010-12-04 07:22:28 UTC
Description of problem:

transmission-daemon has a sys v init script.  We need to include a systemd service(unit) as well.   Several packages in Rawhide have been converted already.  Use those as examples and refer to

https://fedoraproject.org/wiki/TomCallaway/Systemd_Revised_Draft

Since systemd service file would be consistent across all systemd users including Fedora (and in the future openSUSE et all),  this should be filed upstream as well so that other distros can benefit from the conversion we have done.

Comment 1 Tomasz Torcz 2011-09-10 12:01:29 UTC
Created attachment 522516 [details]
0001-add-systemd-file-659919.patch

unit file + specfile patch.

Although unit file should be proposed upstream, I think they would be happier to take patch with some additional systemd integration - sd_notify() in daemon.c and unit with Type=notify.

Comment 2 Tomasz Torcz 2011-09-10 12:02:12 UTC
Created attachment 522517 [details]
0002-drop-sysconfig-file.patch

Remove sysconfig file.

Comment 3 Praveen Kumar 2011-09-22 16:13:19 UTC
After apply first patch [0001-add-systemd-file-659919.patch] it remove "%" from release section and due to that rpmbuild show error (error: line 3: Illegal char '?' in: Release:2{?dist}). Other then this issue everything seems fine, built for rawhide successfully through koji.

rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3371043

Comment 4 Fedora Update System 2011-09-27 01:58:27 UTC
transmission-2.33-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/transmission-2.33-2.fc16

Comment 5 Fedora Update System 2011-09-27 17:31:35 UTC
Package transmission-2.33-2.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing transmission-2.33-2.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/transmission-2.33-2.fc16
then log in and leave karma (feedback).

Comment 6 Pavol Šimo 2011-10-01 14:06:20 UTC
I see a regression in the patch (or rather lost of functionality): the user is set to transmission and no other customizations of process arguments are possible. There was an option to set TRANSMISSION_HOME, DAEMON_USER and DAEMON_ARGS variables in the sysconfig file. Now it's gone and I see no replacement available.

Comment 7 Tomasz Torcz 2011-10-01 17:10:37 UTC
The system shipped unit file is placed in /lib/... If you create your own unit in /etc (that is /etc/systemd/system/transmission-daemon.service), then unit from /etc will override the one from /lib.

If you want to customize, you have to either:
- copy unit from /lib to /etc and make changes
- create unit in /etc and put inside ".include /lib/systemd/system/transmission-daemon.service" and the lines you want changed (like User=, ExecStart=).

That's how local-admin customization works in systemd and it is not Transmission specific.

Comment 8 Fedora Update System 2011-10-09 19:41:42 UTC
transmission-2.33-2.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.