Bug 660471
| Summary: | Support multiple --addtag and --deltag arguments within a single pvchange cluster command | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | Milan Broz <mbroz> |
| Status: | CLOSED ERRATA | QA Contact: | Corey Marthaler <cmarthal> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.0 | CC: | agk, dwysocha, heinzm, jbrassow, joe.thornber, mbroz, prajnoha, prockai, pvrabec, snagar |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.02.82-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-19 14:27:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Corey Marthaler
2010-12-06 21:20:40 UTC
I am afraid this fails even with 1 argument now, seems like some regression. Anything stranhge here? :-) # pvchange --addtag 1 /dev/sdc -vvvv 2>&1 |grep Locking #locking/cluster_locking.c:472 Locking VG V_vg_test PW (VG) (0x4) #locking/cluster_locking.c:472 Locking VG P_vg_test PW (VG|CACHE) (0x104) #locking/cluster_locking.c:472 Locking VG P_vg_test PW (VG|HOLD|CACHE) (0x124) #locking/cluster_locking.c:472 Locking VG V_vg_test UN (VG) (0x6) #locking/cluster_locking.c:472 Locking VG P_#global UN (VG) (0x6) CLVMD[7f28f700]: Dec 23 14:30:47 doing PRE command LOCK_VG 'P_#global' at 6 (client=0xdb6810) CLVMD[7f28f700]: Dec 23 14:30:47 Writing status 22 down pipe 12 CLVMD[825727a0]: Dec 23 14:30:47 read on PIPE 11: 4 bytes: status: 22 CLVMD[825727a0]: Dec 23 14:30:47 background routine status was 22, sock_client=0xdb6810 This was bug, there is no reason why this shoul not work in cluster.
Fixed by this change upstream (2.02.80):
@@ -288,9 +288,9 @@ int pvchange(struct cmd_context *cmd, int argc, char **argv)
unlock_and_free_vg(cmd, vg, sll->str);
}
}
+ unlock_vg(cmd, VG_GLOBAL);
}
- unlock_vg(cmd, VG_GLOBAL);
(Please not that RFE for supporting addtags + deltags in one command is bug #660467 ) Fix verified in the latest rpms. 2.6.32-94.el6.x86_64 lvm2-2.02.83-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 lvm2-libs-2.02.83-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 lvm2-cluster-2.02.83-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 udev-147-2.31.el6 BUILT: Wed Jan 26 05:39:15 CST 2011 device-mapper-1.02.62-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 device-mapper-libs-1.02.62-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 device-mapper-event-1.02.62-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 device-mapper-event-libs-1.02.62-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 cmirror-2.02.83-2.el6 BUILT: Tue Feb 8 10:10:57 CST 2011 [root@taft-01 ~]# service clvmd status clvmd (pid 3971) is running... Clustered Volume Groups: taft Active clustered Logical Volumes: (none) [root@taft-01 ~]# pvchange --addtag 1 --addtag 2 --addtag 3 /dev/sdb1 /dev/sdc1 Physical volume "/dev/sdb1" changed Physical volume "/dev/sdc1" changed 2 physical volumes changed / 0 physical volumes not changed [root@taft-01 ~]# pvs -a -o +pv_tags /dev/sdb1 taft lvm2 a- 135.66g 135.66g 1,2,3 /dev/sdc1 taft lvm2 a- 135.66g 135.66g 1,2,3 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0772.html |