Bug 661567 - Publican uses grep and sed in XmlClean
Summary: Publican uses grep and sed in XmlClean
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: 2.4
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: 3.0
Assignee: Jeff Fearn 🐞
QA Contact: Ruediger Landmann
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-09 01:01 UTC by Jeff Fearn 🐞
Modified: 2012-10-31 03:11 UTC (History)
2 users (show)

Fixed In Version: 3.0.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-10-31 03:11:30 UTC


Attachments (Terms of Use)

Description Jeff Fearn 🐞 2010-12-09 01:01:08 UTC
Description of problem:
Publican is using grep in XmlClean, to reduce dependencies perl modules should be used to replace grep and sed.

Version-Release number of selected component (if applicable):
2.5

Additional info:

sed usage can be replaced by using File::Inplace.

Comment 1 Jeff Fearn 🐞 2010-12-14 06:04:31 UTC
Switched grep & sed to File::Inplace, added new dep to Build.pl and spec file.

Fixed in revision 1687

FYI we need to make sure PO files are updated cleanly when running clean_ids.

Comment 2 Martin Prpič 2012-04-24 17:50:56 UTC
Verified that File::Inplace is pulled in as a dependency:

]$ cat publican.spec |grep Inplace
BuildRequires:  perl(File::Inplace)
]$ rpm -q publican
publican-3.0-0.fc16.t166.noarch
]$ rpm -qR publican | grep Inplace
perl(File::Inplace)  
]$ cat publican.spec | grep Inplace
BuildRequires:  perl(File::Inplace)
]$ cat Build.PL | grep Inplace
        'File::Inplace'                          => 0,
        'File::Inplace'                          => 0,

Comment 3 Martin Prpič 2012-04-26 20:25:17 UTC
Checked for correctness of IDs after running "publican clean_ids" and all seemed to work fine.

On Fedora 16:

]$ rpm -q publican
publican-3.0-0.fc16.t166.noarch


Note You need to log in before you can comment on or make changes to this bug.