Red Hat Bugzilla – Bug 661567
Publican uses grep and sed in XmlClean
Last modified: 2012-10-30 23:11:30 EDT
Description of problem: Publican is using grep in XmlClean, to reduce dependencies perl modules should be used to replace grep and sed. Version-Release number of selected component (if applicable): 2.5 Additional info: sed usage can be replaced by using File::Inplace.
Switched grep & sed to File::Inplace, added new dep to Build.pl and spec file. Fixed in revision 1687 FYI we need to make sure PO files are updated cleanly when running clean_ids.
Verified that File::Inplace is pulled in as a dependency: ]$ cat publican.spec |grep Inplace BuildRequires: perl(File::Inplace) ]$ rpm -q publican publican-3.0-0.fc16.t166.noarch ]$ rpm -qR publican | grep Inplace perl(File::Inplace) ]$ cat publican.spec | grep Inplace BuildRequires: perl(File::Inplace) ]$ cat Build.PL | grep Inplace 'File::Inplace' => 0, 'File::Inplace' => 0,
Checked for correctness of IDs after running "publican clean_ids" and all seemed to work fine. On Fedora 16: ]$ rpm -q publican publican-3.0-0.fc16.t166.noarch