Bug 661904 - GFS2: Kernel changes necessary to allow growing completely full filesystems.
Summary: GFS2: Kernel changes necessary to allow growing completely full filesystems.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.7
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: rc
: ---
Assignee: Ben Marzinski
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks: 490649 711451 729094
TreeView+ depends on / blocked
 
Reported: 2010-12-09 22:46 UTC by Ben Marzinski
Modified: 2011-09-13 13:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
When GFS2 grew the file system, it never reread the rindex file during the grow. This is necessary for large grows when the file system is almost full, and GFS2 needs to use some of the space allocated earlier in the grow to complete it. Now, if GFS2 fails to reserve the necessary space and the rindex data is not up-to-date, it rereads it, fixing this bug.
Clone Of: 659137
Environment:
Last Closed: 2011-07-21 10:24:09 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
patch to fix rindex growing and truncating problems. (4.17 KB, patch)
2010-12-09 23:07 UTC, Ben Marzinski 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:1065 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.7 kernel security and bug fix update 2011-07-21 09:21:37 UTC

Comment 1 Ben Marzinski 2010-12-09 23:07:51 UTC 
Created attachment 467867 [details]
patch to fix rindex growing and truncating problems.

This patch does a couple of things.

1. It removes gfs2_ri_update_special(), since gfs2_ri_update() works correctly for all callers.

2. It calls gfs2_ri_update() if the rindex list is not uptodate, and gfs2 runs out of space growing the rindex file.  This allows you to use space allocated earlier in the grow to finish the grow.

3. It keeps do_strip() from grabbing the rindex glock, if it is working on the rindex file.  This allows you to truncate the rindex file.
Comment 2 RHEL Program Management 2011-02-01 16:53:52 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 4 Jarod Wilson 2011-02-09 14:57:15 UTC 
in kernel-2.6.18-243.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.
Comment 7 Nate Straz 2011-05-18 18:52:41 UTC 
Verified against kernel-2.6.18-261.el5 and gfs2-utils-0.1.62-30.el5.
Comment 8 errata-xmlrpc 2011-07-21 10:24:09 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-1065.html
Comment 11 Tomas Capek 2011-09-13 13:04:04 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
When GFS2 grew the file system, it never reread the rindex file during the grow. This is necessary for large grows when the file system is almost full, and GFS2 needs to use some of the space allocated earlier in the grow to complete it. Now, if GFS2 fails to reserve the necessary space and the rindex data is not up-to-date, it rereads it, fixing this bug.
Note You need to log in before you can comment on or make changes to this bug.