Spec URL: http://npmccallum.fedorapeople.org/natus/natus.spec SRPM URL: http://npmccallum.fedorapeople.org/natus/natus-0.1.3-1.fc14.src.rpm Description: A robust JavaScript shell built on the Natus meta-engine
I will review this one
$ rpmlint ~/rpmbuild/RPMS/i686/*.rpm natus.i686: W: name-repeated-in-summary C Natus natus.i686: W: no-documentation natus.i686: W: no-manual-page-for-binary natus natus-engine-JavaScriptCore.i686: W: no-documentation natus-libs-devel.i686: W: no-documentation natus-python.i686: W: no-documentation python-natus.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/natus.so natus.so python-natus.i686: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 8 warnings.
$ rpmlint natus-0.1.3-1.fc14.src.rpm natus.src: W: name-repeated-in-summary C Natus 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [1] [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Spec file is legible and written in American English. [x] Spec file lacks Packager, Vendor, PreReq tags. [x] Spec uses macros instead of hard-coded directory names. [x] Package consistently uses macros. [x] Macros in Summary, %description expandable at SRPM build time. [x] PreReq is not used. [x] Requires correct, justified where necessary. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [2] [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)). [x] Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of %install. [x] Package use %makeinstall only when ``make install DESTDIR=...'' doesn't work. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [-] The spec file handles locales properly. [x] Changelog in prescribed format. [ ] Rpmlint output is silent. [x] License field in the package spec file matches the actual license. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!] License file installed when any subpackage combination is installed. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [3,4] [x] Sources contain only permissible code or content. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 01a907b6b94ff11cb5f1e2d9f5a51a9a MD5SUM upstream package : 01a907b6b94ff11cb5f1e2d9f5a51a9a [x] Compiler flags are appropriate. [x] %build honors applicable compiler flags or justifies otherwise. [x] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package does not own files or directories owned by other packages. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Each %files section contains %defattr. [-] No %config files under /usr. [-] %config files are marked noreplace or the reason is justified. No config files [-] Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application. [5] [-] Package contains a valid .desktop file. [x] Package contains code, or permissable content. [-] Package contains a SysV-style init script if in need of one. [x] File names are valid UTF-8. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Package contains no bundled libraries. [x] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Package contains no static executables. [!] Package requires pkgconfig, if .pc files are present. [x] Development .so files in -devel subpackage, if present. [x] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [x] Useful -debuginfo package or justification otherwise. [x] Rpath absent or only used for internal libs. [x] Package does not genrate any conflict. [x] Package does not contains kernel modules. [x] Package is not relocatable. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. [x] Package is not known to require ExcludeArch. [x] Package installs properly. [x] Package obeys FHS, except libexecdir and /usr/target. [x] Package meets the Packaging Guidelines. [6] === SUGGESTED ITEMS === [x] Package functions as described. [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x] SourceX is a working URL. [x] SourceX / PatchY prefixed with %{name}. [x] Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x] Usually, subpackages other than devel should require the base package using a fully versioned dependency. [?] Reviewer should test that the package builds in mock. Not tested [?] Package should compile and build into binary rpms on all supported architectures. Not tested [x] Dist tag is present. [x] Spec use %global instead of %define. [x] Scriptlets must be sane, if used. [x] The placement of pkgconfig(.pc) files are correct. [x] No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x] Packages should try to preserve timestamps of original installed files. [-] File based requires are sane. [!] Man pages included for all executables. [-] Patches link to upstream bugs/comments/lists or are otherwise justified. === Issues === 1. COPYING must be included in all sub packages (add %doc COPYING to all %files sections) 2. Package requires pkgconfig, if .pc files are present. === Final Notes === A man file would be nice, but not a deal breaker :) if 1 & 2 is fixed then I will approve the package [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines [2] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines [4] https://fedoraproject.org/wiki/Licensing:Main [5] https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files [6] https://fedoraproject.org/wiki/Packaging:Guidelines
#1 - License file installed when any subpackage combination is installed. COPYING is installed when -libs is installed. All other packages depend on -libs. This should satisfy the requirement. #2 - Good catch on the .pc. Added. http://npmccallum.fedorapeople.org/natus/natus.spec I didn't rebuild the SRPM.
Looks good *** APPROVED ***
Thanks! New Package SCM Request ======================= Package Name: natus Short Description: A robust JavaScript shell built on the Natus meta-engine Owners: npmccallum Branches: f13 f14 el6 InitialCC:
Git done (by process-git-requests).
natus-0.1.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/natus-0.1.3-2.fc14
natus-0.1.3-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/natus-0.1.3-2.fc13
natus-0.1.3-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update natus'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/natus-0.1.3-2.fc13
natus-0.1.3-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
natus-0.1.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.