Bug 662668 - confusing options --key & --keys in pulp-admin repo create
Summary: confusing options --key & --keys in pulp-admin repo create
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: unspecified
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: ---
Assignee: Pradeep Kilambi
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks: verified-to-close
TreeView+ depends on / blocked
 
Reported: 2010-12-13 15:02 UTC by Preethi Thomas
Modified: 2011-07-15 19:29 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-02-17 16:51:47 UTC
Embargoed:


Attachments (Terms of Use)

Description Preethi Thomas 2010-12-13 15:02:38 UTC
Description of problem:




pulp-admin repo create has --key & --keys options. It would be less confusing to change one to something else.

[root@pulp ~]# pulp-admin repo create --help

 --key=KEY             path location to entitlement certificate key



 --keys=KEYS           a ',' separated list of directories and/or files
                        contining GPG keys

Comment 1 Pradeep Kilambi 2010-12-22 20:02:33 UTC
commit 1fd6eb4977230b26c1f83b78affc5f599df0a28e
Author: Pradeep Kilambi <pkilambi>
Date:   Wed Dec 22 15:02:06 2010 -0500

    662668 - renaming keys to gpgkeys for clarity

$ pulp-admin repo create --help
Usage: pulp-admin <options> repo create <options>

Options:
  -h, --help            show this help message and exit
  --id=ID               repository id (required)
  --name=NAME           common repository name
  --arch=ARCH           package arch the repository should support
  --feed=FEED           url feed to populate the repository; feed format is
                        type:url, where supported types include yum,rhn or
                        local
  --cacert=CACERT       path location to ca certificate
  --cert=CERT           path location to entitlement certificate
  --key=KEY             path location to entitlement certificate key
  --schedule=SCHEDULE   cron entry date and time syntax for scheduling
                        automatic repository synchronizations
  --symlinks            use symlinks instead of copying bits locally;
                        applicable for local syncs
  --relativepath=RELATIVEPATH
                        relative path where the repository is stored and
                        exposed to clients; this defaults to feed path if not
                        specified
  --groupid=GROUPID     a group to which the repository belongs; this is just
                        a string identifier
  --gpgkeys=KEYS        a ',' separated list of directories and/or files
                        contining GPG keys

Comment 2 Jay Dobies 2010-12-22 20:56:31 UTC
Fixed in 0.119.

Comment 3 Preethi Thomas 2010-12-23 15:11:39 UTC
[root@pulp ~]# rpm -q pulp
pulp-0.0.119-1.fc14.noarch


[root@pulp ~]# pulp-admin repo create --help
Usage: pulp-admin <options> repo create <options>

Options:
  -h, --help            show this help message and exit
  --id=ID               repository id (required)
  --name=NAME           common repository name
  --arch=ARCH           package arch the repository should support
  --feed=FEED           url feed to populate the repository; feed format is
                        type:url, where supported types include yum,rhn or
                        local
  --cacert=CACERT       path location to ca certificate
  --cert=CERT           path location to entitlement certificate
  --key=KEY             path location to entitlement certificate key
  --schedule=SCHEDULE   cron entry date and time syntax for scheduling
                        automatic repository synchronizations
  --symlinks            use symlinks instead of copying bits locally;
                        applicable for local syncs
  --relativepath=RELATIVEPATH
                        relative path where the repository is stored and
                        exposed to clients; this defaults to feed path if not
                        specified
  --groupid=GROUPID     a group to which the repository belongs; this is just
                        a string identifier
  --gpgkeys=KEYS        a ',' separated list of directories and/or files
                        contining GPG keys

Comment 4 Preethi Thomas 2011-02-17 16:51:47 UTC
Closing with community release 

pulp-0.0.139-1.fc14.noarch


Note You need to log in before you can comment on or make changes to this bug.