Spec URL: http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-1.fc13.src.rpm Description: Implements support of RESTful resources with Rails MVC when Javascript is off and bulk operations are required with multiple submit buttons.
Taking this for review: Overall this package looks safe to me, just one issue, please fix wrong email in %changelog section. Formal review: * Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. PASS * The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version FAILED: Please fix it using: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem * The package must have a Requires and a BuildRequires on rubygems PASS * The %prep and %build sections of the specfile should be empty. PASS * The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) PASS * The install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} PASS * The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec PASS * If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch. PASS
(In reply to comment #1) > Taking this for review: > > Overall this package looks safe to me, just one issue, please fix wrong email > in %changelog section. [FIXED] > * The Source of the package must be the full URL to the released Gem archive; > the version of the package must be the Gem's version > > FAILED: > Please fix it using: > http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem > [FIXED] New SPEC URL: http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec New SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-2.fc13.src.rpm
Nice, One more thing: Please fix this URL using defined macro (%gemname) before you import this package to Fedora: URL: https://github.com/martincik/rack-restful_submit REVIEW+
(In reply to comment #3) > Nice, > > One more thing: > Please fix this URL using defined macro (%gemname) before you import this > package to Fedora: > > URL: https://github.com/martincik/rack-restful_submit > > REVIEW+ Nice catch and thanks for review. New SPEC URL: http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec New SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-3.fc13.src.rpm
(In reply to comment #4) > (In reply to comment #3) > > Nice, > > > > One more thing: > > Please fix this URL using defined macro (%gemname) before you import this > > package to Fedora: > > > > URL: https://github.com/martincik/rack-restful_submit > > > > REVIEW+ > > Nice catch and thanks for review. > > New SPEC URL: > http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec > New SRPM URL: > http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-3.fc13.src.rpm Sorry the name of SPEC file was wrong, so here is the right ones: New SPEC URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit.spec New SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-3.fc13.src.rpm
New Package SCM Request ======================= Package Name: rubygem-rack-restful_submit Short Description: Allows RESTful routing without Javascript and multiple submit buttons Owners: jzigmund Branches: f13 f14
Git done (by process-git-requests).
rubygem-rack-restful_submit-1.1.1-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1-3.fc13
rubygem-rack-restful_submit-1.1.1-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1-3.fc14
rubygem-rack-restful_submit-1.1.2-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.2-1.fc13
rubygem-rack-restful_submit-1.1.2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.2-1.fc14
rubygem-rack-restful_submit-1.1.1-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-rack-restful_submit'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1-3.fc14
rubygem-rack-restful_submit-1.1.2-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-rack-restful_submit-1.1.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.