Bug 663058 - Review Request: rubygem-rack-restful_submit - Allows RESTful routing without Javascript and multiple submit buttons
Summary: Review Request: rubygem-rack-restful_submit - Allows RESTful routing without ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Fojtik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-14 15:18 UTC by Jozef Zigmund
Modified: 2011-01-03 20:03 UTC (History)
3 users (show)

Fixed In Version: rubygem-rack-restful_submit-1.1.2-1.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-03 20:03:21 UTC
Type: ---
Embargoed:
mfojtik: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Jozef Zigmund 2010-12-14 15:18:27 UTC
Spec URL: http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec
SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-1.fc13.src.rpm
Description: Implements support of RESTful resources with Rails MVC when Javascript is off and bulk operations are required with multiple submit buttons.

Comment 1 Michal Fojtik 2010-12-14 15:53:16 UTC
Taking this for review:

Overall this package looks safe to me, just one issue, please fix wrong email in %changelog section.

Formal review:

* Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.

     PASS

* The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version

    FAILED:
    Please fix it using: 
    http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem

* The package must have a Requires and a BuildRequires on rubygems
  
   PASS

* The %prep and %build sections of the specfile should be empty.

   PASS

* The Gem must be installed into %{gemdir} defined as 
  %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)

  PASS

* The install should be performed with the command
  gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}

  PASS

* The package must own the following files and directories: 
  %{gemdir}/gems/%{gemname}-%{version}/
  %{gemdir}/cache/%{gemname}-%{version}.gem
  %{gemdir}/specifications/%{gemname}-%{version}.gemspec

  PASS

* If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch. 
   
  PASS

Comment 2 Jozef Zigmund 2010-12-14 16:08:10 UTC
(In reply to comment #1)
> Taking this for review:
> 
> Overall this package looks safe to me, just one issue, please fix wrong email
> in %changelog section.

[FIXED]

> * The Source of the package must be the full URL to the released Gem archive;
> the version of the package must be the Gem's version
> 
>     FAILED:
>     Please fix it using: 
>     http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
> 

[FIXED]

New SPEC URL: http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec
New SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-2.fc13.src.rpm

Comment 3 Michal Fojtik 2010-12-14 16:12:19 UTC
Nice,

One more thing:
Please fix this URL using defined macro (%gemname) before you import this package to Fedora:

URL: https://github.com/martincik/rack-restful_submit

REVIEW+

Comment 4 Jozef Zigmund 2010-12-14 16:25:17 UTC
(In reply to comment #3)
> Nice,
> 
> One more thing:
> Please fix this URL using defined macro (%gemname) before you import this
> package to Fedora:
> 
> URL: https://github.com/martincik/rack-restful_submit
> 
> REVIEW+

Nice catch and thanks for review.

New SPEC URL: http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec
New SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-3.fc13.src.rpm

Comment 5 Jozef Zigmund 2010-12-14 16:57:31 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Nice,
> > 
> > One more thing:
> > Please fix this URL using defined macro (%gemname) before you import this
> > package to Fedora:
> > 
> > URL: https://github.com/martincik/rack-restful_submit
> > 
> > REVIEW+
> 
> Nice catch and thanks for review.
> 
> New SPEC URL:
> http://people.redhat.com/jzigmund/rubygem-rack_restful_submit.spec
> New SRPM URL:
> http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-3.fc13.src.rpm

Sorry the name of SPEC file was wrong, so here is the right ones:
New SPEC URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit.spec
New SRPM URL: http://people.redhat.com/jzigmund/rubygem-rack-restful_submit-1.1.1-3.fc13.src.rpm

Comment 6 Jozef Zigmund 2010-12-14 16:59:36 UTC
New Package SCM Request
=======================
Package Name:      rubygem-rack-restful_submit
Short Description: Allows RESTful routing without Javascript and multiple submit buttons
Owners:            jzigmund
Branches:          f13 f14

Comment 7 Jason Tibbitts 2010-12-14 17:27:18 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2010-12-14 18:23:02 UTC
rubygem-rack-restful_submit-1.1.1-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1-3.fc13

Comment 9 Fedora Update System 2010-12-14 18:26:22 UTC
rubygem-rack-restful_submit-1.1.1-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1-3.fc14

Comment 10 Fedora Update System 2010-12-15 16:37:01 UTC
rubygem-rack-restful_submit-1.1.2-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.2-1.fc13

Comment 11 Fedora Update System 2010-12-15 16:37:05 UTC
rubygem-rack-restful_submit-1.1.2-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.2-1.fc14

Comment 12 Fedora Update System 2010-12-17 08:27:40 UTC
rubygem-rack-restful_submit-1.1.1-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-rack-restful_submit'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1-3.fc14

Comment 13 Fedora Update System 2011-01-03 20:03:16 UTC
rubygem-rack-restful_submit-1.1.2-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2011-01-03 20:03:46 UTC
rubygem-rack-restful_submit-1.1.2-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.