Bug 663206 - [RFE] publican creates invalid spec files
Summary: [RFE] publican creates invalid spec files
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: future
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Jeff Fearn 🐞
QA Contact: Ruediger Landmann
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-14 23:36 UTC by Jeff Fearn 🐞
Modified: 2011-07-26 00:42 UTC (History)
3 users (show)

Fixed In Version: 2.6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-26 00:42:32 UTC
Embargoed:


Attachments (Terms of Use)

Description Jeff Fearn 🐞 2010-12-14 23:36:28 UTC
Description of problem:
It is invalid for summary and description to be epty or only contain white space. Currently Publican will happily generate invalid spec files if these fields contain white space.

Version-Release number of selected component (if applicable):
2.5

Actual results:
Packages that fail rpmlint are created when subtitle or abstract only contain white space.

Expected results:
Publican should refuse to create invalid packages.

Comment 1 Jeff Fearn 🐞 2010-12-15 02:28:53 UTC
Added code to check subtitle and abstract are valid before creating spec file. tar.gz file will still be created regardless of RPM issues.

Fixed in revision 1690

Comment 2 Jeff Fearn 🐞 2011-07-05 09:27:38 UTC
Back ported to branches/publican-2x

Committed revision 1800.

Comment 3 Rebecca Newton 2011-07-13 00:40:57 UTC
Hi Jeff, I'm trying to build a set and I am getting:

WARNING: You can not create RPM packages with a blank subtitle. Skipping RPM creation.
pushd tmp
Use of uninitialized value in subroutine entry at /usr/bin/publican line 910.
Can't locate srpm, CVS import aborted at /usr/bin/publican line 912

This is expected, due to this update, but both the Set_Info.xml and the Book_Info.xmls for the included books HAVE subtitles, so this error probably shouldn't show up, should it?

Comment 4 Rebecca Newton 2011-07-13 00:58:36 UTC
It does work fine for books, though.

Comment 7 Rebecca Newton 2011-07-13 04:54:32 UTC
Fix verified. I can't reproduce the earlier bug. I must have been looking at it wrong.


Note You need to log in before you can comment on or make changes to this bug.