Red Hat Bugzilla – Bug 663222
[Cisco 6.1 bug] Fix memory leak in fnic and bump version to 1.5.0.1
Last modified: 2011-05-19 08:21:24 EDT
Description of problem: Memory allocated for fnic stats wasn't being properly freed in vnic_dev.c, leading to memory leaks. This patch fixes that. The fnic version is also being bumped up from 1.4.0.145 to 1.5.0.1 to better align the driver with future platform releases. Separate patches are attached for both fixes. These patches will be submitted upstream in the near future. Version-Release number of selected component (if applicable): old version: 1.4.0.145 new version: 1.5.0.1 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 468741 [details] Patch bumping up fnic version
Created attachment 468742 [details] Memory leak fix
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Hey Venkata, In the future please include the upstream git commit with the patch, so our reviewers can easily match the patch with what went upstream. I looked up the commits for these patches. Thanks Mike
(In reply to comment #5) > Hey Venkata, > > In the future please include the upstream git commit with the patch, so our > reviewers can easily match the patch with what went upstream. I looked up the > commits for these patches. > Actually, I goofed. Where are these patches upstream?
(In reply to comment #6) > (In reply to comment #5) > > Hey Venkata, > > > > In the future please include the upstream git commit with the patch, so our > > reviewers can easily match the patch with what went upstream. I looked up the > > commits for these patches. > > > > Actually, I goofed. Where are these patches upstream? Hi Mike! Actually the patches I've attached haven't been submitted upstream yet - do they have to be submitted upstream before you can merge them in? Please let me know. Regards, Vijayendra.
> Hi Mike! > > Actually the patches I've attached haven't been submitted upstream yet - do > they have to be submitted upstream before you can merge them in? Please let me > know. > > Regards, > Vijayendra. Yes, this is a requirement.
(In reply to comment #8) > > Hi Mike! > > > > Actually the patches I've attached haven't been submitted upstream yet - do > > they have to be submitted upstream before you can merge them in? Please let me > > know. > > > > Regards, > > Vijayendra. > > Yes, this is a requirement. Hi Mike, Andrius, I've submitted the patches upstream today. When they get merged into the fcoe-next.git tree, I will paste the links to the git tree in this bz. Regards, Vijayendra.
Vijayendra, Did this make it upstream? We have to get it there before we can get it into RHEL. -Gary
Hi Gary, The patches made it upstream, pasting the links below - http://www.open-fcoe.org/git/?p=fcoe/fcoe-next.git;a=commitdiff;h=d608380a88990cc59b9c50c41d868fc5d4febe7a http://www.open-fcoe.org/git/?p=fcoe/fcoe-next.git;a=commitdiff;h=1107efcbc25bce95751eb017437c788f86fb5c65 Please let me know if you're unable to access the links. Regards, Vijayendra. (In reply to comment #10) > Vijayendra, > > Did this make it upstream? We have to get it there before we can get it into > RHEL. > > -Gary
Hi Vijayendra, I can see the patches using the links you provided. Thanks! -Gary
Patch(es) available on kernel-2.6.32-112.el6
~~ Partners and Customers ~~ This bug was included in RHEL 6.1 Beta. Please confirm the status of this request as soon as possible. If you're having problems accessing 6.1 bits, are delayed in your test execution or find in testing that the request was not addressed adequately, please let us know. Thanks!
Hi Vijayendra, This bug needs to be partner verified.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-0542.html