RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 663222 - [Cisco 6.1 bug] Fix memory leak in fnic and bump version to 1.5.0.1
Summary: [Cisco 6.1 bug] Fix memory leak in fnic and bump version to 1.5.0.1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.1
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: 6.1
Assignee: Mike Christie
QA Contact: Storage QE
URL:
Whiteboard:
Depends On:
Blocks: 580566
TreeView+ depends on / blocked
 
Reported: 2010-12-15 02:17 UTC by Venkata Siva Vijayendra Bhamidipati
Modified: 2011-05-19 12:21 UTC (History)
6 users (show)

Fixed In Version: kernel-2.6.32-112.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-19 12:21:24 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Patch bumping up fnic version (627 bytes, text/plain)
2010-12-15 02:17 UTC, Venkata Siva Vijayendra Bhamidipati 		no flags Details
Memory leak fix (745 bytes, text/plain)
2010-12-15 02:18 UTC, Venkata Siva Vijayendra Bhamidipati 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0542 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update 2011-05-19 11:58:07 UTC

Description Venkata Siva Vijayendra Bhamidipati 2010-12-15 02:17:07 UTC 
Description of problem:

Memory allocated for fnic stats wasn't being properly freed in vnic_dev.c, leading to memory leaks. This patch fixes that. The fnic version is also being bumped up from 1.4.0.145 to 1.5.0.1 to better align the driver with future platform releases. Separate patches are attached for both fixes.

These patches will be submitted upstream in the near future.


Version-Release number of selected component (if applicable):

old version: 1.4.0.145
new version: 1.5.0.1


How reproducible:

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Venkata Siva Vijayendra Bhamidipati 2010-12-15 02:17:42 UTC 
Created attachment 468741 [details]
Patch bumping up fnic version
Comment 2 Venkata Siva Vijayendra Bhamidipati 2010-12-15 02:18:13 UTC 
Created attachment 468742 [details]
Memory leak fix
Comment 4 RHEL Program Management 2010-12-15 23:40:08 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.
Comment 5 Mike Christie 2010-12-18 20:47:17 UTC 
Hey Venkata,

In the future please include the upstream git commit with the patch, so our reviewers can easily match the patch with what went upstream. I looked up the commits for these patches.

Thanks

Mike
Comment 6 Mike Christie 2010-12-18 20:49:42 UTC 
(In reply to comment #5)
> Hey Venkata,
> 
> In the future please include the upstream git commit with the patch, so our
> reviewers can easily match the patch with what went upstream. I looked up the
> commits for these patches.
> 

Actually, I goofed. Where are these patches upstream?
Comment 7 Venkata Siva Vijayendra Bhamidipati 2010-12-19 16:38:31 UTC 
(In reply to comment #6)
> (In reply to comment #5)
> > Hey Venkata,
> > 
> > In the future please include the upstream git commit with the patch, so our
> > reviewers can easily match the patch with what went upstream. I looked up the
> > commits for these patches.
> > 
> 
> Actually, I goofed. Where are these patches upstream?



Hi Mike!

Actually the patches I've attached haven't been submitted upstream yet - do they have to be submitted upstream before you can merge them in? Please let me know.

Regards,
Vijayendra.
Comment 8 Andrius Benokraitis 2010-12-20 06:04:52 UTC 
> Hi Mike!
> 
> Actually the patches I've attached haven't been submitted upstream yet - do
> they have to be submitted upstream before you can merge them in? Please let me
> know.
> 
> Regards,
> Vijayendra.

Yes, this is a requirement.
Comment 9 Venkata Siva Vijayendra Bhamidipati 2010-12-21 03:35:06 UTC 
(In reply to comment #8)
> > Hi Mike!
> > 
> > Actually the patches I've attached haven't been submitted upstream yet - do
> > they have to be submitted upstream before you can merge them in? Please let me
> > know.
> > 
> > Regards,
> > Vijayendra.
> 
> Yes, this is a requirement.

Hi Mike, Andrius,

I've submitted the patches upstream today. When they get merged into the fcoe-next.git tree, I will paste the links to the git tree in this bz.

Regards,
Vijayendra.
Comment 10 Gary Case 2011-01-12 20:22:37 UTC 
Vijayendra,

Did this make it upstream? We have to get it there before we can get it into RHEL.

-Gary
Comment 12 Venkata Siva Vijayendra Bhamidipati 2011-01-12 20:51:01 UTC 
Hi Gary,

The patches made it upstream, pasting the links below -

http://www.open-fcoe.org/git/?p=fcoe/fcoe-next.git;a=commitdiff;h=d608380a88990cc59b9c50c41d868fc5d4febe7a

http://www.open-fcoe.org/git/?p=fcoe/fcoe-next.git;a=commitdiff;h=1107efcbc25bce95751eb017437c788f86fb5c65

Please let me know if you're unable to access the links.

Regards,
Vijayendra.


(In reply to comment #10)
> Vijayendra,
> 
> Did this make it upstream? We have to get it there before we can get it into
> RHEL.
> 
> -Gary
Comment 13 Gary Case 2011-01-12 21:06:41 UTC 
Hi Vijayendra,

I can see the patches using the links you provided. Thanks!

-Gary
Comment 16 Aristeu Rozanski 2011-02-03 16:45:21 UTC 
Patch(es) available on kernel-2.6.32-112.el6
Comment 20 Chris Ward 2011-04-06 11:15:34 UTC 
~~ Partners and Customers ~~

This bug was included in RHEL 6.1 Beta. Please confirm the status of this request as soon as possible.

If you're having problems accessing 6.1 bits, are delayed in your test execution or find in testing that the request was not addressed adequately, please let us know.

Thanks!
Comment 21 Jason Willeford 2011-05-09 16:42:53 UTC 
Hi Vijayendra,
This bug needs to be partner verified.
Comment 22 errata-xmlrpc 2011-05-19 12:21:24 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html
Note You need to log in before you can comment on or make changes to this bug.