Description of problem: ip(8) man page has spelling and grammar errors Version-Release number of selected component (if applicable): iproute-2.6.18-11.el5 How reproducible: Always Steps to Reproduce: man 8 ip Additional info: diff ip.8 ip_fixed 1063c1063 < the commoand flushes the contents of address labels and it does not restore default settings. --- > the command flushes the contents of address labels and it does not restore default settings. 1101c1101 < is an abbreviation for 'Neigh bour Unreachability Detection'. --- > is an abbreviation for 'Neighbour Unreachability Detection'. 1425c1425 < routing code to maintain compatability with previous releases. --- > routing code to maintain compatibility with previous releases. 2225c2225 < It can be used these algoritms --- > Valid algorithms are:
Thanks for the report, John. Some of those were still present in the current upstream version; they should be fixed in 2.6.36.
Created attachment 469165 [details] Patch for iproute-2.6.18-11.el5
Created attachment 469166 [details] Patch for iproute2-git-1e21ea71a7e12e6bd06ece8cf415e7a5f372c806 Submitted upstream.
Thanks Petr. Should I always give diffs using the --git option? Found a few other typos in other man pages so would like to make this as easy as possible for the maintainers next time. Anything else I should include?
(In reply to comment #5) > Thanks Petr. > > Should I always give diffs using the --git option? Found a few other typos in > other man pages so would like to make this as easy as possible for the > maintainers next time. > > Anything else I should include? John, It's all about the maintainer's choice; I suppose unified diff is usually the preferred option, though. I'm looking forward to more patches from you :) Also, for your information, the changes have been accepted upstream. Petr
Started adding diff -u patches to my other reports :) Thanks for the tutorial as well as sorting this ticket.
Moving this bug to Fedora as agreed with the reporter. I apologize if the manpage typo/grammar error was already fixed in version included in the Fedora, if that's the case, feel free to close the bug.
Fixed upstream, see comments 1 and 3. Available in iproute-2.6.37-1.fc15 and newer.