Bug 664190 - Wrong "addr" Spice parameter in libvirt 0.8.6
Summary: Wrong "addr" Spice parameter in libvirt 0.8.6
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Daniel Veillard
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-19 01:05 UTC by Amador Pahim
Modified: 2011-03-01 11:19 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-03-01 11:19:35 UTC
Embargoed:

Attachments (Terms of Use)
patch disabling addr (1.29 KB, patch)
2011-01-30 23:22 UTC, Julian Sikorski 		no flags Details | Diff
Patch that actually works (931 bytes, patch)
2011-01-30 23:29 UTC, Julian Sikorski 		no flags Details | Diff
final patch version (1.62 KB, patch)
2011-01-31 00:11 UTC, Julian Sikorski 		no flags Details | Diff
Show Obsolete (2) View All

Description Amador Pahim 2010-12-19 01:05:51 UTC 
Description of problem:
Running libvirt 0.8.6, spice parameters does not work

Version-Release number of selected component:
0.8.6

Steps to Reproduce:
Change VM XML file to this (instead VNC):
<graphics type='spice' port='5903' />

Try to start VM with:
# virsh start Ubuntu

Actual results:
error: Failed to start domain Ubuntu
error: internal error Process exited while reading console log output: qemu-kvm: -spice port=5903,addr=127.0.0.1,disable-ticketing: Invalid parameter 'addr'
parse error: port=5903,addr=127.0.0.1,disable-ticketing

Expected results:
Domain Ubuntu started

Additional info:
To fix that, I had to edit the "src/qemu/qemu_command.c", in libvirt source, commenting this lines:

/*
 *       if (def->graphics[0]->data.spice.listenAddr)
 *          virBufferVSprintf(&opt, ",addr=%s", def->graphics[0] >data.spice.listenAddr);
 *       else if (driver->spiceListen)
 *          virBufferVSprintf(&opt, ",addr=%s", driver->spiceListen);
 */
Comment 1 Julian Sikorski 2011-01-30 23:22:17 UTC 
Created attachment 476095 [details]
patch disabling addr

I tried patching the rawhide srpm with the attached patch, but it fails to build on f14 mock giving errors like:
/usr/lib/gcc/x86_64-redhat-linux/4.5.1/include/stdarg.h:40:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'typedef'
Comment 2 Julian Sikorski 2011-01-30 23:29:05 UTC 
Created attachment 476096 [details]
Patch that actually works

Erm, after posting this I realised where I screwed up. Feel free to ignore me, it's late.
Comment 3 Julian Sikorski 2011-01-30 23:38:17 UTC 
Well, I spoke too soon. The qemuxml2argvtest which are a part of rpm build process fails.
Comment 4 Julian Sikorski 2011-01-31 00:11:05 UTC 
Created attachment 476100 [details]
final patch version

The final version also disables the failing test so that the SRPM can be rebuilt.
Comment 5 Julian Sikorski 2011-03-01 07:30:03 UTC 
$ rpm -q spice-client libvirt
spice-client-0.7.2-1.fc14.x86_64
libvirt-0.8.8-2.fc14.x86_64

With these packages everything seems to work. Looking at the logs it seems spice accepts addr parameter now.
Comment 6 Daniel Berrangé 2011-03-01 11:19:35 UTC 
The problem here is that in the Fedora 14 version of QEMU, the SPICE support is done via a set of non-upstream patches. These patches did not include the 'addr' element. libvirt is designed to work with the upstream QEMU codebase. I have verified that it works with the Fedora 15 version fo QEMU.
Note You need to log in before you can comment on or make changes to this bug.