Spec URL: http://tnorth.fedorapeople.org/autojump.spec SRPM URL: http://tnorth.fedorapeople.org/autojump-14-1.fc14.src.rpm Description: autojump is a faster way to navigate your filesystem. It works by maintaining a database of the directories you use the most from the command line.
Before formal review. It build filed on El5: http://koji.fedoraproject.org/koji/taskinfo?taskID=2676375 If you plan maintain it for EL5 too, please fix it. If you don't plan do that, please gone BuildRoot, %clean and similar stuff.
It seems that the problem occurs because rpmbuild uses xz for compression that epel can not unpack. I updated the srpm, now created with rpmbuild-md5. It builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=2676428 Thanks, Thibault
Legend: + - Ok. - - Error. +/- - It item acceptable, but I strongly recommend enhancement. = - N/A. MUST Items [+] MUST: rpmlint must be run on every package. The output should be posted in the review. $ rpmlint * autojump.noarch: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systematic autojump.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic autojump.noarch: W: no-manual-page-for-binary jumpapplet autojump.src: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systematic autojump.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic autojump-zsh.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic autojump-zsh.noarch: W: no-documentation 3 packages and 1 specfiles checked; 0 errors, 7 warnings. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+/-] MUST: The package must meet the Packaging Guidelines. > gzip %{name}.1 is not necessary - mans gzipped automatically. > %{_bindir}/* I'm prefer exact mention files to avoid acidentally includes in this and next builds: %{_bindir}/%{name} %{_bindir}/jumpapplet > %{_datadir}/%{name}* In case it globed into %{_datadir}/%{name} its ok, but for whate there asterisk?? If package name changed directory also changed. I'm highly recommend replace it by include just one directory: %{_datadir}/%{name} >%{_mandir}/man1/%{name}* %{_mandir}/man1/%{name}.1* also more preferred. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [-] MUST: The License field in the package spec file must match the actual license. README.rst stated it should be GPLv3+, not exactly GPLv3. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ md5sum autojump_v14.tar.gz.downloaded autojump_v14.tar.gz.fromrpm 7c0a41a2d33aee11a844dc17f7825dc9 autojump_v14.tar.gz.downloaded 7c0a41a2d33aee11a844dc17f7825dc9 autojump_v14.tar.gz.fromrpm [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [=] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [=] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [=] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [=] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [-] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. File listed twice: %{_datadir}/zsh/site-functions/ %{_datadir}/zsh/site-functions/_j [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [=] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [=] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [=] MUST: Header files must be in a -devel package. [=] MUST: Static libraries must be in a -static package. [=] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). [=] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [=] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [=] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [=] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [=] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [=] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [=] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [+/-] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. Please consider full version dependency opposite only name. But in case of scripts it ma be unnecessary. On packager decision. [=] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [=] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
Thanks a lot for your review. I applied your suggestions and re-uploaded the package and the spec at the same address. > gzip %{name}.1 >is not necessary - mans gzipped automatically. Right, thanks. > %{_bindir}/* >I'm prefer exact mention files to avoid acidentally includes in this and next >builds: >%{_bindir}/%{name} >%{_bindir}/jumpapplet Done. > %{_datadir}/%{name}* >In case it globed into %{_datadir}/%{name} its ok, but for whate there >asterisk?? If package name changed directory also changed. >I'm highly recommend replace it by include just one directory: >%{_datadir}/%{name} Done. >%{_mandir}/man1/%{name}* >%{_mandir}/man1/%{name}.1* >also more preferred. Done. >[-] MUST: The License field in the package spec file must match the actual >license. >README.rst stated it should be GPLv3+, not exactly GPLv3. Right, sorry. >File listed twice: >%{_datadir}/zsh/site-functions/ >%{_datadir}/zsh/site-functions/_j This I forgot to remove :) Done. [+/-] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. Done. Thank you.
Please post new spec and src.rpm files to review.
Here you go. Spec URL: http://tnorth.fedorapeople.org/autojump.spec SRPM URL: http://tnorth.fedorapeople.org/autojump-14-2.fc14.src.rpm Thanks, Thibault
Only one question left: Why you use %dir %{_datadir}/zsh/site-functions/ %{_datadir}/zsh/site-functions/_j but not just owning full directory: %{_datadir}/zsh/site-functions/ ? I think in your case it is equivalent - there no other files. Meantime, it is fully on your choose, all major issues gone. PACKAGE APPROVED.
I was not sure how to handle directories belonging zsh so I used another spec (mercurial) including a zsh module. Thanks a lot for the review, Thibault
I see no SCM request to process here.
Sorry I missed that step :) New Package SCM Request ======================= Package Name: autojump Short Description: A fast way to navigate your filesystem from the command line Owners: tnorth Branches: f13 f14 el5 el6 InitialCC:
Git done (by process-git-requests).
autojump-14-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/autojump-14-2.fc13
autojump-14-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update autojump'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/autojump-14-2.fc13
autojump-14-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.