Bug 664911 - Review Request: perl-Test-WWW-Mechanize-PSGI - Test PSGI programs using WWW::Mechanize
Summary: Review Request: perl-Test-WWW-Mechanize-PSGI - Test PSGI programs using WWW::...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ruediger Landmann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 664910
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-22 04:56 UTC by Ralf Corsepius
Modified: 2011-02-13 08:58 UTC (History)
3 users (show)

Fixed In Version: perl-Test-WWW-Mechanize-PSGI-0.35-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-02-13 08:51:06 UTC
Type: ---
Embargoed:
rc040203: fedora_requires_release_note?
rlandman: fedora-review+
notting: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2010-12-22 04:56:31 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Test-WWW-Mechanize-PSGI.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Test-WWW-Mechanize-PSGI-0.35-1.fc15.src.rpm

Description:
PSGI is a specification to decouple web server environments from web
application framework code. Test::WWW::Mechanize is a subclass of
WWW::Mechanize that incorporates features for web application testing. The
Test::WWW::Mechanize::PSGI module meshes the two to allow easy testing of
PSGI applications.

Comment 1 Ruediger Landmann 2011-02-01 03:04:27 UTC
Looks good to me:

 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [/] Rpmlint output is clean:
$ rpmlint SRPMS/perl-Test-WWW-Mechanize-PSGI-0.35-1.fc14.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/perl-Test-WWW-Mechanize-PSGI-0.35-1.fc14.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint RPMS/noarch/perl-Test-WWW-Mechanize-PSGI-0.35-1.fc14.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Language specific
items
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [/] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [/] Spec file is legible and written in American English.
 [/] Sources used to build the package matches the upstream source, as provided
in the spec URL.
$ md5sum SOURCES/Test-WWW-Mechanize-PSGI-0.35.tar.gz 
f8403d6ccdef06aacb9092715e2dde26  SOURCES/Test-WWW-Mechanize-PSGI-0.35.tar.gz
$ md5sum ~/Download/Test-WWW-Mechanize-PSGI-0.35.tar.gz 
f8403d6ccdef06aacb9092715e2dde26  /home/rlandmann/Download/Test-WWW-Mechanize-PSGI-0.35.tar.gz

 [/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2753997
 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly (with the %find_lang macro)
 [-] ldconfig called in %post and %postun if required.
 [/] Package does not bundle copies of system libraries
 [/] Package is not relocatable.
 [/] Package must own all directories that it creates.
 [/] Package does not contain duplicates in %files.
 [/] Permissions on files are set properly
 [/] %files section includes a %defattr(...) line
 [/] Package consistently uses macros.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Development .so files in -devel subpackage, if present.
 [-] -devel packages require base package with full versioning.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.
 [/] Filenames are valid UTF-8

For the sake of completeness, I note that certain items are not required unless you want to build this for EPEL:

* BuildRoot:
* rm -rf $RPM_BUILD_ROOT in the %install section
* the whole %clean section

But I know you already know this :)

In any case: ACCEPTED

Comment 2 Ralf Corsepius 2011-02-01 06:30:48 UTC
(In reply to comment #1)
> * BuildRoot:
> * rm -rf $RPM_BUILD_ROOT in the %install section
> * the whole %clean section
> 
> But I know you already know this :)
Sure ... I am deliberately keeping them to prevent harm from "unaware users", who try rebuilding these rpms on aging OSes :(

> In any case: ACCEPTED
Thanks, Rudi.


New Package SCM Request
=======================
Package Name: perl-Test-WWW-Mechanize-PSGI
Short Description: Test PSGI programs using WWW::Mechanize
Owners: corsepiu
Branches: f13 f14
InitialCC: perl-sig

Comment 3 Bill Nottingham 2011-02-02 22:32:38 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-02-03 06:08:46 UTC
perl-Test-WWW-Mechanize-PSGI-0.35-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Test-WWW-Mechanize-PSGI-0.35-1.fc14

Comment 5 Fedora Update System 2011-02-03 06:08:53 UTC
perl-Test-WWW-Mechanize-PSGI-0.35-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Test-WWW-Mechanize-PSGI-0.35-1.fc13

Comment 6 Fedora Update System 2011-02-03 20:19:51 UTC
perl-Test-WWW-Mechanize-PSGI-0.35-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Test-WWW-Mechanize-PSGI'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-Test-WWW-Mechanize-PSGI-0.35-1.fc13

Comment 7 Fedora Update System 2011-02-13 08:51:01 UTC
perl-Test-WWW-Mechanize-PSGI-0.35-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2011-02-13 08:58:17 UTC
perl-Test-WWW-Mechanize-PSGI-0.35-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.