Bug 664932 - Review Request: perl-HTML-Mason-PSGIHandler - PSGI handler for HTML::Mason
Summary: Review Request: perl-HTML-Mason-PSGIHandler - PSGI handler for HTML::Mason
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
Depends On: 664910
Blocks: rt4-dependencies-tracker
TreeView+ depends on / blocked
Reported: 2010-12-22 06:55 UTC by Ralf Corsepius
Modified: 2011-02-04 19:54 UTC (History)
2 users (show)

Fixed In Version: perl-HTML-Mason-PSGIHandler-0.52-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-02-04 19:53:52 UTC
Type: ---
mmaslano: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)

Description Ralf Corsepius 2010-12-22 06:55:25 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-HTML-Mason-PSGIHandler.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-HTML-Mason-PSGIHandler-0.52-1.fc15.src.rpm

HTML::Mason::PSGIHandler is a PSGI handler for HTML::Mason. It's based on
HTML::Mason::CGIHandler and allows you to process Mason templates on any
web servers that support PSGI.

Comment 1 Marcela Mašláňová 2011-01-25 16:17:46 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 ^ http://koji.fedoraproject.org/koji/taskinfo?taskID=2741515
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -q --provides perl-HTML-Mason-PSGIHandler
perl(HTML::Mason::PSGIHandler) = 0.52
perl(HTML::Mason::PSGIHandler::Streamy) = 0.52
perl(HTML::Mason::Request::PSGI) = 0.52
perl-HTML-Mason-PSGIHandler = 0.52-1.fc15

rpm -q --requires perl-HTML-Mason-PSGIHandler
perl >= 0:5.008_001
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1


Comment 2 Ralf Corsepius 2011-01-26 03:25:04 UTC
Thanks for the review, Marcela!

New Package SCM Request
Package Name: perl-HTML-Mason-PSGIHandler
Short Description: PSGI handler for HTML::Mason
Owners: corsepiu
Branches: f13 f14
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-01-26 17:56:27 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-01-27 03:18:43 UTC
perl-HTML-Mason-PSGIHandler-0.52-1.fc13 has been submitted as an update for Fedora 13.

Comment 5 Fedora Update System 2011-01-27 03:18:50 UTC
perl-HTML-Mason-PSGIHandler-0.52-1.fc14 has been submitted as an update for Fedora 14.

Comment 6 Ralf Corsepius 2011-01-27 03:22:27 UTC
@Marcela: This package has the same issues as has outlined for perl-HTML-Quoted 
in https://bugzilla.redhat.com/show_bug.cgi?id=664812#c6

I imported 2 different versions of the spec: The one from this review for f15 and one with explict Requires added for f13/f14.

Comment 7 Fedora Update System 2011-01-27 20:56:09 UTC
perl-HTML-Mason-PSGIHandler-0.52-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-HTML-Mason-PSGIHandler'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-HTML-Mason-PSGIHandler-0.52-1.fc14

Comment 8 Fedora Update System 2011-02-04 19:53:46 UTC
perl-HTML-Mason-PSGIHandler-0.52-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2011-02-04 19:54:11 UTC
perl-HTML-Mason-PSGIHandler-0.52-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.