Bug 665032 - NIC unplug in qemu-dm will also unplug passthrough NICs
Summary: NIC unplug in qemu-dm will also unplug passthrough NICs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: xen
Version: 5.7
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: rc
: ---
Assignee: Don Dutile (Red Hat)
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 514500 634472
TreeView+ depends on / blocked
 
Reported: 2010-12-22 13:45 UTC by Paolo Bonzini
Modified: 2011-07-21 12:00 UTC (History)
8 users (show)

Fixed In Version: xen-3.0.3-126.el5
Doc Type: Bug Fix
Doc Text:
When a Red Hat Enterprise Linux 6.1 fully-virtualized Xen guest requested an unplug of emulated network cards, the qemu-dm device model would also disconnect host network cards that were passed-through to the guest. This bug has been fixed, and now the pass-through NICs (Network Interface Cards) remain functioning for Red Hat Enterprise Linux 6.1 guests.
Clone Of:
Environment:
Last Closed: 2011-07-21 09:16:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1070 0 normal SHIPPED_LIVE xen bug fix and enhancement update 2011-07-21 09:12:56 UTC

Description Paolo Bonzini 2010-12-22 13:45:09 UTC
I found these patches in xen-unstable qemu.git.  I've not tried to reproduce it as my machine(s) do not have an IOMMU, but the bug is pretty obvious in retrospect.

60b80e3ee319e908069d1603e5b73f815acdffac
      passthrough: magic ioport protocol no longer unplugs passthrough NICs

f187eeb8546405d57eb421cdd329d804ee734d23
      passthrough: magic protocol passthrough fix no-passthrough compile

Comment 1 Paolo Bonzini 2010-12-22 13:48:53 UTC
Just a note that this affects RHEL6 guests only.

Comment 2 Paolo Bonzini 2010-12-22 13:54:07 UTC
Related bugs:

- bug 515238 introduced the regression

- RHEL6.0 bug 632021 masked it, but it will (re)appear on 6.1

Comment 4 Don Dutile (Red Hat) 2010-12-23 20:13:14 UTC
Paolo,
can you provide a ptr to the xen-unstable qemu.git tree? thanks... Don

Comment 5 Paolo Bonzini 2011-01-03 12:22:16 UTC
[remote "xen"]
        url = git://xenbits.xensource.com/qemu-xen-unstable.git
        fetch = +refs/heads/*:refs/remotes/xen/*

Comment 7 john cooper 2011-01-13 22:00:15 UTC
moving to 5.7 per triage assessment.

Comment 18 Miroslav Rezanina 2011-03-17 09:55:15 UTC
Fix built into xen-3.0.3-126.el5

Comment 20 Qixiang Wan 2011-04-21 13:30:03 UTC
Verified with xen-3.0.3-129.el5.

$ cat guest.cfg
...
pci = ['0000:03:10.2','0000:03:10.3']
vif = ["mac=00:16:36:55:50:21,bridge=xenbr0,script=vif-bridge,type=ioemu",
"mac=00:16:36:55:50:22,bridge=xenbr0,script=vif-bridge,type=ioemu"]
...

reproduced with xen-3.0.3-120.el5 + RHEL6.1 snapshot4 (kernel-2.6.32-131.0.1), (no xen_emul_unplug=* parameter in guest kernel cmdline), both the pass-through nics and xen emulated nics are unpluged.

after update to xen-3.0.3-129.el5, boot up guest with same configuration, can see the pass-through nics within the guest, so the fix works.

Comment 21 Tomas Capek 2011-07-13 13:29:53 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
When a Network Interface Card (NIC) was disconnected by the qemu-dm daemon, all associated pass-through NICs, such as various PCI devices, were disconnected as well. This bug has been fixed and now the pass-through NICs remain connected and functioning in the described scenario.

Comment 22 Paolo Bonzini 2011-07-13 14:58:55 UTC
qemu-dm is not a daemon; mentioned explicitly which guests request unplug to qemu-dm.

Comment 23 Paolo Bonzini 2011-07-13 14:58:55 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-When a Network Interface Card (NIC) was disconnected by the qemu-dm daemon, all associated pass-through NICs, such as various PCI devices, were disconnected as well. This bug has been fixed and now the pass-through NICs remain connected and functioning in the described scenario.+When a Red Hat Enterprise Linux 6.1 fully-virtualized Xen guest requested unplug of emulated network cards, qemu-dm would also disconnect host network cards that were passed-through to the guest. This bug has been fixed and now the pass-through NICs remain functioning for Red Hat Enterprise Linux 6.1 guests.

Comment 24 Tomas Capek 2011-07-14 13:50:50 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-When a Red Hat Enterprise Linux 6.1 fully-virtualized Xen guest requested unplug of emulated network cards, qemu-dm would also disconnect host network cards that were passed-through to the guest. This bug has been fixed and now the pass-through NICs remain functioning for Red Hat Enterprise Linux 6.1 guests.+When a Red Hat Enterprise Linux 6.1 fully-virtualized Xen guest requested an unplug of emulated network cards, the qemu-dm device model would also disconnect host network cards that were passed-through to the guest. This bug has been fixed, and now the pass-through NICs (Network Interface Cards) remain functioning for Red Hat Enterprise Linux 6.1 guests.

Comment 25 errata-xmlrpc 2011-07-21 09:16:08 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-1070.html

Comment 26 errata-xmlrpc 2011-07-21 12:00:53 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-1070.html


Note You need to log in before you can comment on or make changes to this bug.