Bug 665045 - patchelf doesn't preserve ACLs and file based capabilities
Summary: patchelf doesn't preserve ACLs and file based capabilities
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: patchelf
Version: 19
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jeremy Sanders
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-22 14:25 UTC by Miroslav Franc
Modified: 2016-02-01 02:27 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-02-17 13:32:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miroslav Franc 2010-12-22 14:25:48 UTC
Description of problem:
patchelf doesn't preserve ACLs and file based capabilities


Version-Release number of selected component (if applicable):
patchelf-0.5-6.fc15.x86_64


How reproducible:
every time on x86_64 f14 and rawhide


Steps to Reproduce:
---
[root@pokus]# echo '#include<stdio.h>' > test.c
[root@pokus]# echo 'int main() { puts("hello, world"); return 0; }' > test.c 
[root@pokus]# gcc test.c  
[root@pokus]# ./a.out 
hello, world
[root@pokus]# setcap cap_audit_write+pe ./a.out 
[root@pokus]# setfacl -m u:root:rwx ./a.out 
[root@pokus]# getcap ./a.out 
./a.out = cap_audit_write+ep
[root@pokus]# getfacl ./a.out 
# file: a.out
# owner: root
# group: root
user::rwx
user:root:rwx
group::rwx
mask::rwx
other::r-x

[root@pokus]# patchelf --set-interpreter `patchelf --print-interpreter  ./a.out` ./a.out 
[root@pokus]# getcap ./a.out 
[root@pokus]# getfacl ./a.out 
# file: a.out
# owner: root
# group: root
user::rwx
group::rwx
other::r-x

[root@pokus]# ./a.out 
hello, world
---


Actual results:
ACLs and file based capabilities are erased.


Expected results:
ACLs and file based capabilities are preserved.


Additional info:
tested on x86_64, probably won't work anywhere, I didn't test it elsewhere nor did I look at the source code

Comment 1 Jeremy Sanders 2010-12-27 12:13:33 UTC
Thanks for the report - I've reported the bug upstream. I'll have a look if they are not responsive.

Comment 2 Jeremy Sanders 2011-12-03 11:01:59 UTC
Sorry for the long delay. Upstream didn't respond, so I've patched this myself. I'll submit the patch upstream if it fixes the problem. It seems to fix the examples above for me.

It should be fixed in patchelf-0.6-1: http://koji.fedoraproject.org/koji/buildinfo?buildID=276941   Please verify if you can.

The patch is here if you are able to verify its correctness:
http://pkgs.fedoraproject.org/gitweb/?p=patchelf.git;a=blob_plain;f=patchelf-copy-attr.patch;hb=HEAD
(self tests still succeed)

Comment 3 Fedora End Of Life 2013-04-03 18:39:45 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 4 Fedora End Of Life 2015-01-09 16:29:27 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2015-02-17 13:32:48 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.