Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Starlet.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Starlet-0.13-1.fc15.src.rpm
Starlet is a standalone HTTP/1.0 server with keep-alive support, formerly
known as Plack::Server::Standalone::Prefork and
+ source files match upstream.
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock
+ package installs properly.
+ rpmlint has no complaints:
perl-Starlet.src: W: spelling-error %description -l en_US Prefork -> Preform, Proreform, Prefatory
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ final provides and requires are sane:
perl(Plack::Server::Standalone::Prefork::Server::Starter) = 0.07
perl(Starlet) = 0.13
perl-Starlet = 0.13-1.fc16
perl >= 0:5.008_001
+ %check is present and all tests pass.
All tests successful.
Files=4, Tests=94, 4 wallclock secs ( 0.03 usr 0.01 sys + 1.10 cusr 0.22 csys = 1.36 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
I think the description is a little weak. If it were mine, I would rewrite it, but it's up to you:
Starlet is a standalone HTTP/1.0 server with support for keep-alive, prefork, graceful shutdown, hot deploy, fast HTTP processing, and is suitable for running HTTP application servers behind a reverse proxy.
Thanks for the review, Iain.
The description is what upstream uses (inherited through cpanspec), but you're right, it's improveable - I'll change the description to your proposal after Git import.
New Package SCM Request
Package Name: perl-Starlet
Short Description: Simple, high-performance PSGI/Plack HTTP server
Branches: f13 f14 f15
Git done (by process-git-requests).