Bug 665240
| Summary: | [RFE] Increase the command line length limit of the FTP client beyond 200 characters. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Brad Hubbard <bhubbard> | ||||||
| Component: | ftp | Assignee: | Jan Synacek <jsynacek> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Zbysek MRAZ <zmraz> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5.4 | CC: | bgollahe, ebenes, ksrot, lmiksik, plyons, pmedilal, rdassen, rvokal, syeghiay | ||||||
| Target Milestone: | rc | Keywords: | FutureFeature, Patch, Triaged | ||||||
| Target Release: | 5.9 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 665337 665833 852739 (view as bug list) | Environment: | |||||||
| Last Closed: | 2013-01-08 07:44:48 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 665833, 665834, 726492, 824469, 838996, 852739 | ||||||||
| Attachments: |
|
||||||||
|
Description
Brad Hubbard
2010-12-23 05:05:23 UTC
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. This request was erroneously denied for the current release of Red Hat Enterprise Linux. The error has been fixed and this request has been re-proposed for the current release. I have uploaded a patch for this (an adaptation of Nalin's patch for bz 6658330 and tested as below. This needs a lot more testing and QA though. Steps to Reproduce: 1. mkdir -p /tmp/sourcedir1/sourcedir2/sourcedir3/sourcedir4/sourdir5/sourdir6/sourcedir7/sourcedir8/sourcedir9/sourcedir10/sourcedir11/sourcedir12/sourcedir13/sourcedir14/sourcedir15/sourcedir16/sourcedir17/sourcedir18/ 2. echo test > /tmp/sourcedir1/sourcedir2/sourcedir3/sourcedir4/sourdir5/sourdir6/sourcedir7/sourcedir8/sourcedir9/sourcedir10/sourcedir11/sourcedir12/sourcedir13/sourcedir14/sourcedir15/sourcedir16/sourcedir17/sourcedir18/source 3. echo -e "user anonymous password\ncd incoming\nput /tmp/sourcedir1/sourcedir2/sourcedir3/sourcedir4/sourdir5/sourdir6/sourcedir7/sourcedir8/sourcedir9/sourcedir10/sourcedir11/sourcedir12/sourcedir13/sourcedir14/sourcedir15/sourcedir16/sourcedir17/sourcedir18/source target2" > /tmp/command 4. ./ftp -v -n dropbox.redhat.com</tmp/command Connected to dropbox.redhat.com (209.132.183.100). 220-+---------------------------------------------------------------+ 220-| Welcome to Red Hat Global Support Services FTP! | 220-| | 220-| Please note: the "ls" command is disabled by design. | 220-| You will receive this error if you attempt to run "ls": | 220-| | 220-| ls: 550 Permission denied. | 220-| | 220-| If you are uploading a file for Technical Support, you | 220-| must include your support ticket number in the filename | 220-| and inform your technician of the upload. Files with names | 220-| that do not follow this convention, such as vmcore or | 220-| vmcore.gz will be deleted. | 220-| | 220-| To upload a core successfully, please do the following: | 220-| | 220-| ftp> cd incoming | 220-| ftp> put [casenumber]-[file] | 220-| | 220-| - Active and passive transfers are supported. | 220-| - Upload resume is supported. | 220-+---------------------------------------------------------------+ 220 331 Please specify the password. 230 Login successful. 250 Directory successfully changed. local: /tmp/sourcedir1/sourcedir2/sourcedir3/sourcedir4/sourdir5/sourdir6/sourcedir7/sourcedir8/sourcedir9/sourcedir10/sourcedir11/sourcedir12/sourcedir13/sourcedir14/sourcedir15/sourcedir16/sourcedir17/sourcedir18/source remote: target2 227 Entering Passive Mode (209,132,183,100,25,17) 150 Ok to send data. 226 File receive OK. 6 bytes sent in 4.4e-05 secs (1.3e+02 Kbytes/sec) 221 Goodbye. Created attachment 504369 [details]
Proposed patch, needs testing.
Needs testing, compiles without error, solves bz issue and passes basic testing.
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. Created attachment 601744 [details]
[Patch] increase line buffer length limit
I suggest fixing this by simply increasing the line buffer length to PATH_MAX plus a margin (I left the original 200 there) for the ftp command. The filename cannot be longer than PATH_MAX anyway.
There is no need to modify other functionality of the code.
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. Hi Jan, is the PATH_MAX limit related to a single filename? Correct me if I am wrong bug you are allowed to pass multiple files to mget/mput commands. Can't you reach that "argbuf[PATH_MAX + 200]" limit this way? > is the PATH_MAX limit related to a single filename? Yes. > Can't you reach that "argbuf[PATH_MAX + 200]" limit this way? I didn't manage to do so. If you call mput <file1> <file2> ... <file_n> you will hit the command line limit. On the other hand, if you first call the mput command, then ftp's use of readline() will not let you to type more than 4095 (PATH_MAX-1) characters. Currently (without the patch), the latter will cause a buffer overflow anyway, so I think that changing both line and argbuf to PATH_MAX+1 exactly should be enough. If you managed to call mput with more than PATH_MAX-1 characters, please let me know and I will change the argbuf's length to ARG_MAX+1, which should be enough. But I don't think that will be necessary. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2013-0102.html |