Bug 665388 - jakarta-* jars have been renamed to apache-*, pkicreate fails Fedora 14 and above
Summary: jakarta-* jars have been renamed to apache-*, pkicreate fails Fedora 14 and a...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Dogtag Certificate System
Classification: Retired
Component: Installer (pkicreate/pkiremove)
Version: 9.0
Hardware: Unspecified
OS: Unspecified
low
urgent
Target Milestone: ---
Assignee: RHCS Maintainers
QA Contact: Ben Levenson
URL:
Whiteboard:
Depends On:
Blocks: dogtagIPAv2
TreeView+ depends on / blocked
 
Reported: 2010-12-23 14:37 UTC by John Dennis
Modified: 2020-03-27 20:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-27 20:03:05 UTC
Embargoed:


Attachments (Terms of Use)
setup pki instance jars by searching the installed jars (29.36 KB, patch)
2010-12-29 04:52 UTC, John Dennis
no flags Details | Diff
setup pki instance jars by searching the installed jars (32.22 KB, patch)
2010-12-29 05:06 UTC, John Dennis
no flags Details | Diff
setup pki instance jars by searching the installed jars (32.22 KB, patch)
2010-12-29 06:44 UTC, John Dennis
alee: review+
Details | Diff

Description John Dennis 2010-12-23 14:37:37 UTC
Starting with Fedora 14 jars and classes which were named jakarata have been renamed to apache. We need to detect the flavour of the Java installation and adjust the names we use in pkicreate when setting up the links to the jars.

We may also need to adjust any BuildRequires, Requires in our spec files and/or CMakeLists.txt which reference the affected jars.

We seem to be fortunate in that we do not appear to reference any jakarta class via an import in our Java code, therefore this seems to be a jar rename issue only.

The Fedora rename work is tracked by this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=588764

Comment 1 John Dennis 2010-12-29 04:52:53 UTC
Created attachment 471031 [details]
setup pki instance jars by searching the installed jars

This patch does 3 fundamental things:

1) Adds a utility to find the path to a jar (find_jar)

2) Sets up the pki instance jars by calling find_jar() instead of hard coding their expected location.

3) Conditions the commons-logging and commons-lang jar depending on whether apache-commons is found, else falls back to jakarta-commons

In addition the patch organizes the jar variables, jar setup, etc. by alphabetical jar name so things are consistent and easier to find in the source code.

Comment 2 John Dennis 2010-12-29 05:06:32 UTC
Created attachment 471032 [details]
setup pki instance jars by searching the installed jars

updated patch to check return values

Comment 3 John Dennis 2010-12-29 06:44:34 UTC
Created attachment 471034 [details]
setup pki instance jars by searching the installed jars

Fix the jar search path order, the pki directory should come first giving it highest precedence.

Comment 4 John Dennis 2011-01-04 13:17:06 UTC
Sending        setup/pkicommon.pm
Sending        setup/pkicreate
Transmitting file data ..
Committed revision 1684.


Note You need to log in before you can comment on or make changes to this bug.