Spec URL: http://taljurf.fedorapeople.org/Packages/i686/gnome-paint/gnome-paint.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/gnome-paint/gnome-paint-0.4.0-1.fc13.src.rpm Description: gnome-paint is a simple, easy to use paint program for GNOME. It is inspired by MS-Paint. KOJI URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=2692898 Note: The problem in bug 566745 was that there were unimplemented features which looked like bugs, but now the problem is solved.
*** Bug 566745 has been marked as a duplicate of this bug. ***
1) I'd rather use desktop-file-validate instead of desktop-file-install, since the desktop file is already installed at the right place 2) There is a warning when validating the desktop file, this should fix it : sed -i 's|RasterGraphics;|2DGraphics;RasterGraphics;|g' data/desktop/%{name}.desktop.in.in 3) You can take the manpage from debian repos and include it ( not necessary though )
Sorry, I didn't do #3 But here's the result: Spec URL: http://taljurf.fedorapeople.org/Packages/i686/gnome-paint/gnome-paint.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/gnome-paint/gnome-paint-0.4.0-2.fc13.src.rpm KOJI URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=2712738
PING, hicham
Package Review ============== Package: Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines [x] Spec file name must match the base package %{name}, in the format %{name}.spec [x] Package meets the Packaging Guidelines [x] Package successfully compiles and builds into binary RPMs on at least one supported architecture Tested on: F14/x86_64 [!] Rpmlint output: Source RPM: [fab@laptop023 SRPMS]$ rpmlint gnome-paint-0.4.0-2.fc13.src.rpm gnome-paint.src: W: strange-permission gnome-paint.spec 0755L 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Binary RPM(s): [fab@laptop023 x86_64]$ rpmlint gnome-paint* gnome-paint.x86_64: W: no-manual-page-for-binary gnome-paint 2 packages and 0 specfiles checked; 0 errors, 1 warnings. [x] Package is not relocatable [x] Buildroot is correct (if it's still used) master : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) spec file: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?] License field in the package spec file matches the actual license License type: GPLv3+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc [x] Spec file is legible and written in American English [x] Sources used to build the package matches the upstream source, as provided in the spec URL Upstream source: a6c71a0daf065f7bd238b59e598c5f30 gnome-paint-0.4.0.tar.gz Build source: a6c71a0daf065f7bd238b59e598c5f30 gnome-paint-0.4.0.tar.gz [x] Package is not known to require ExcludeArch [-] Architecture independent packages have: BuildArch: noarch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x] The spec file handles locales properly. %find_lang used for locales [x] %{optflags} or RPM_OPT_FLAGS are honoured [-] ldconfig called in %post and %postun if required [x] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT (if it's still used) [x] Package must own all directories that it creates [x] Package requires other packages for directories it uses [x] Package does not own files or directories owned by other packages [x] Package does not contain duplicates in %files [x] Permissions on files are set properly. %defattr(-,root,root,-) is in every %files section [x] Package uses nothing in %doc for runtime [x] Package has a %clean section, which contains rm -rf %{buildroot} or $RPM_BUILD_ROOT (if it's still used) [-] Included tests passed successfully [!] Package consistently uses macros [x] Package contains code, or permissable content [x] Included filenames are in UTF-8 [-] Large documentation files are in a -doc subpackage, if required [-] Header files (.h) in -devel subpackage, if present [-] Fully versioned dependency in subpackage, if present [-] Static libraries (.a) in -static subpackage, if present [-] Package requires pkgconfig, if .pc files are present [-] Development .so files in -devel subpackage, if present [x] Package does not contain any libtool archives (.la) [x] -debuginfo subpackage is present and looks complete [x] No pre-built binaries (.a, .so*, executable) [x] Package contains a properly installed .desktop file if it is a GUI application [x] Follows desktop entry spec [x] Valid .desktop Name [x] Valid .desktop GenericName [x] Valid .desktop Categories [x] Valid .desktop StartupNotify [x] .desktop file installed with desktop-file-install in %install === SUGGESTED ITEMS === [?] Timestamps preserved with cp and install [?] Uses parallel make (%{?_smp_mflags}) [?] Latest version is packaged [?] Package does not include license text files separate from upstream [?] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available [?] Package should compile and build into binary RPMs on all supported architectures. Tested: [x] Package functions as described [x] Scriptlets must be sane, if used [-] The placement of pkgconfig(.pc) files is correct [-] File based requires are sane [x] Changelog in allowed format - In the %files section you are not using macros. - The scriplet for the desktop-database is missing. Check https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo - I think there is no comment needed for the validation of the desktop file. - Consider to change the URL to lauchpad because the first thing you see on their google page is that they moved. Please fix the issues and we are good to go.
All done except for the mimeinfo, could you explain why it's necessary? Looking back at the spec, I believe I'm not installing any mime info.
Sorry, the link was wrong for the desktop-database https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
Can you provide a new SRPM with the fixes?
Sorry for the delay, There you go: Spec URL: http://taljurf.fedorapeople.org/Packages/i686/gnome-paint/gnome-paint.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/gnome-paint/gnome-paint-0.4.0-3.fc13.src.rpm KOJI URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=2968516
Sorry a mistake in SRPM URL: SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/gnome-paint/gnome-paint-0.4.0-3.fc14.src.rpm
(In reply to comment #5) > - In the %files section you are not using macros. This is your call if you want to use macros in the %files section. it's not a blocker. > - The scriplet for the desktop-database is missing. Scriptlet was added > - Consider to change the URL to lauchpad because the first thing you see on > their google page is that they moved. was changed. > [x] Package should compile and build into binary RPMs on all supported > architectures. Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2991868 Can you please remove 'GNOME' from the description and the summary before the git import? The usage is not limited to Gnome. I see no further blocker, package APPROVED.
You can go on with the VCS process and import the package.
Sorry, almost forgot about it. Last build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3081156
New Package CVS Request ======================= Package Name: gnome-paint Short Description: Easy to use paint program Owners: taljurf Branches: F-13 F-15 InitialCC: taljurf
Git done (by process-git-requests).
Sorry, forgot to add F-14: Package Change Request ====================== Package Name: gnome-paint New Branches: F-14 Owners: taljurf InitialCC: taljurf
Tareq, can you please build the package?
Sorry, I was in my final exams >>> building now :)
gnome-paint-0.4.0-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gnome-paint-0.4.0-4.fc14
gnome-paint-0.4.0-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-paint-0.4.0-4.fc15
gnome-paint-0.4.0-4.fc15 has been pushed to the Fedora 15 testing repository.
gnome-paint-0.4.0-4.fc15 has been pushed to the Fedora 15 stable repository.
gnome-paint-0.4.0-4.fc14 has been pushed to the Fedora 14 stable repository.