Description of problem: legacy rhts ran in the foreground using the console. change beah to default to this mode.
Note: reservesys may give us little trouble: we want console to be available during reservesys. The easiest way may be test would not use the rhts-compat service which would be stopped by harness in that case. 1. Update harness 2. Update the reservesys task 3. Test: This is not highly disruptive change, but make sure followig test-cases pass: * "RhtsOptions: [-]Compatible" - to allow access to console * RHTS_OPTION_COMPATIBLE param * check in non-compatible mode test does not use rhts-compat and vice-versa * check rhts-compat is stopped for non-compatible tests * reservesys test - check the task does not run in compatible mode and the console is available (check rhts-compat service is not running in this case.) * test sequence of tests altering compatible/no-compatible mode
Testing the changes (deployed on beaker-stage right now.)
Patches for review == patch1: WIP: Compatible mode improved == http://git.fedorahosted.org/git/?p=beah.git;a=commitdiff;h=9b64a562b204692d5b774e2f846894d473230675 === Comments === This patch makes the stop/start for rhts-compat service more fail-proof. The issue is rhts-compat is not a regular service: it captures the console and runs in foreground spawning any launchers it finds until stopped. On 'service stop' it does not stop immediately: I wanted it to execute all queued launchers and stop only after some safety delay, to allow easy service restart without rebooting machine. == patch2: Added: source environmnt for rhts tasks. == http://git.fedorahosted.org/git/?p=beah.git;a=commitdiff;h=a3ebc794eb14a43c5119b2f533b720ac79aca170 === Comments === Just an auxiliary thing: I wanted an easy way to modify environment which the tests use by either defining defaults and also overriding any parameters and think this may be useful and though there is a better way, this is a quick solution... == patch3: Use rhts-compat service by default http://git.fedorahosted.org/git/?p=beah.git;a=commitdiff;h=fea2d89e58047ee26339ba14e6050faf21dbbf94 Added RHTS_OPTION_COMPAT_SERVICE param/option to stop service when unused (e.g. for reservesys): the service will be stopped when task runs in non-compatible mode and this variable is empty. === Comments === We need a way to specify when the compat-service is to be stopped e.g. for reservesys task. Requires a new [undocumented yet] option for task's metadata: this is in my TODO waiting for feature to be deployed. The rhts package was already committed by Bill :-) == patch4: rhts-compat: avoid /tmp == http://git.fedorahosted.org/git/?p=beah.git;a=commitdiff;h=ba26d3a85496bba26f295404ed42bc470c6ad596 === Comments === Simple change just to avoid /tmp - there is an effort to move off /tmp as required by few people... == patch5: rhts-compat exit codes == http://git.fedorahosted.org/git/?p=beah.git;a=commitdiff;h=f15fbb6864f060c603571bdb133869bf336bb36b Make status return LSB compliant exit codes. There is an exception when service is running but was killed already and the killer file is present. === Comments === Another simple change to make exit codes more standard... == patch6: Fixed: compat uses login shell and set PWD == http://git.fedorahosted.org/git?p=beah.git;a=commitdiff;h=bdb23c9b73101f9bb246ec729961e3b29db8624b Changing directory to TESTPATH and using login shell. This works on EL4, while previous version did not. === Comment === I omitted this in compat service while it was used in non-compat mode. Without it few things (el4 among them) were not working...