Spec URL: http://www.auroralinux.org/people/spot/review/new/avoision.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/avoision-0.6-1.fc14.src.rpm Description: Avoision is a straightforward, yet captivating distillation of vintage arcade entertainment requiring strategy, precision, and perseverance with a singular objective: capture the red square while evading innumerable cruel, spiteful white squares. Note: This depends on Radius-Engine (bz 667205)
Build fails due to missing radius-engine-devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=2702017 http://koji.fedoraproject.org/koji/taskinfo?taskID=2702030
Well, I did mark this bug as depending on Radius-Engine (bz 667205), and mention that explicitly above...
The package fails to build in mock because BR: zip is missing (required to create %{_datadir}/avoision/avoision.zip).
New SRPM: http://www.auroralinux.org/people/spot/review/new/avoision-0.6-2.fc14.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/avoision.spec Koji Scratch Build (dist-f15): http://koji.fedoraproject.org/koji/taskinfo?taskID=2857900
The package looks fine. According to http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net, the "project" directory should be removed from Source0. However, it also works as it is now. $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm avoision.x86_64: W: no-manual-page-for-binary avoision 3 packages and 0 specfiles checked; 0 errors, 1 warnings. The warning is expected as there's no manpage available. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. application: GPLv2+ audio/graphic files: CC-BY-SA [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum avoision-0.6.tar.gz* 5e6aa929624b385dc83fbd80c97d9529 avoision-0.6.tar.gz 5e6aa929624b385dc83fbd80c97d9529 avoision-0.6.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied. [.] MUST: The spec file MUST handle locales properly. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file. [+] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, ... [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- Package APPROVED ----------------
New Package SCM Request ======================= Package Name: avoision Short Description: Arcade style game of evade and capture Owners: spot Branches: f13 f14 f15 InitialCC:
Git done (by process-git-requests). Didn't create f13, not taking any new branches.
avoision-0.6-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/avoision-0.6-2.fc14
avoision-0.6-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/avoision-0.6-2.fc15
avoision-0.6-2.fc15 has been pushed to the Fedora 15 testing repository.
avoision-0.6-2.fc14 has been pushed to the Fedora 14 stable repository.
avoision-0.6-2.fc15 has been pushed to the Fedora 15 stable repository.