Bug 667403 - Review Request: perl-Dist-CheckConflicts - Declare version conflicts for your dist
Summary: Review Request: perl-Dist-CheckConflicts - Declare version conflicts for your...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-05 14:27 UTC by Paul Howarth
Modified: 2011-03-18 14:54 UTC (History)
2 users (show)

Fixed In Version: perl-Dist-CheckConflicts-0.02-2.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-18 14:54:28 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2011-01-05 14:27:42 UTC
Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Dist-CheckConflicts/branches/fedora/perl-Dist-CheckConflicts.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Dist-CheckConflicts/perl-Dist-CheckConflicts-0.02-2.fc15.src.rpm

Description:
One shortcoming of the CPAN clients that currently exist is that they have no
way of specifying conflicting downstream dependencies of modules. This module
attempts to work around this issue by allowing you to specify conflicting
versions of modules separately, and deal with them after the module is done
installing.

For instance, say you have a module Foo, and some other module Bar uses Foo. If
Foo were to change its API in a non-backwards-compatible way, this would cause
Bar to break until it is updated to use the new API. Foo can't just depend on
the fixed version of Bar, because this will cause a circular dependency
(because Bar is already depending on Foo), and this doesn't express intent
properly anyway - Foo doesn't use Bar at all. The ideal solution would be for
there to be a way to specify conflicting versions of modules in a way that would
let CPAN clients update conflicting modules automatically after an existing
module is upgraded, but until that happens, this module will allow users to do
this manually.


This package is needed for Package::Stash 0.20.

It is compatible with EPEL-4 once its dependencies List::MoreUtils, Sub::Exporter and its dependencies Data::OptList, Params::Util, Sub::Install and Package::Generator are available - I am working on getting these built now.

Comment 1 Marcela Mašláňová 2011-01-06 12:35:39 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides ../RPMS/noarch/perl-Dist-CheckConflicts-0.02-2.fc14.noarch.rpm 
perl-Dist-CheckConflicts = 0.02-2.fc14
rpm -qp --requires ../RPMS/noarch/perl-Dist-CheckConflicts-0.02-2.fc14.noarch.rpm
perl(:MODULE_COMPAT_5.12.2)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

ACCEPT

Comment 2 Paul Howarth 2011-01-06 12:51:30 UTC
New Package SCM Request
=======================
Package Name: perl-Dist-CheckConflicts
Short Description: Declare version conflicts for your dist
Owners: pghmcfc
Branches: f13 f14 el4 el5 el6
InitialCC: perl-sig

Thanks for the review Marcela; unfortunately you set the fedora-cvs flag rather than the fedora-review flag, so could you please fix that?

Comment 3 Marcela Mašláňová 2011-01-06 13:03:48 UTC
I'm sorry. Fixed.

Comment 4 Jason Tibbitts 2011-01-06 14:44:42 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2011-01-06 15:28:16 UTC
perl-Dist-CheckConflicts-0.02-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Dist-CheckConflicts-0.02-2.fc14

Comment 6 Fedora Update System 2011-01-06 15:28:23 UTC
perl-Dist-CheckConflicts-0.02-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Dist-CheckConflicts-0.02-2.fc13

Comment 7 Fedora Update System 2011-01-06 15:28:29 UTC
perl-Dist-CheckConflicts-0.02-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Dist-CheckConflicts-0.02-2.el5

Comment 8 Fedora Update System 2011-01-14 20:30:47 UTC
perl-Dist-CheckConflicts-0.02-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2011-01-14 20:36:15 UTC
perl-Dist-CheckConflicts-0.02-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2011-01-21 19:21:36 UTC
perl-Dist-CheckConflicts-0.02-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2011-03-01 07:22:37 UTC
Package perl-Dist-CheckConflicts-0.02-2.el4:
* should fix your issue,
* was pushed to the Fedora EPEL 4 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Dist-CheckConflicts-0.02-2.el4'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/perl-Dist-CheckConflicts-0.02-2.el4
then log in and leave karma (feedback).

Comment 12 Fedora Update System 2011-03-16 18:18:43 UTC
perl-Dist-CheckConflicts-0.02-2.el4 has been pushed to the Fedora EPEL 4 stable repository.


Note You need to log in before you can comment on or make changes to this bug.