Hide Forgot
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo.spec SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo-0.3.23-1.fc14.src.rpm Description: TZInfo uses the tz database (www.twinsun.com/tz/tz-link.htm) to provide daylight-savings aware transformations between times in different timezones. This is the same database as used for zoneinfo on Unix machines. The tz database has been imported (using TZDataParser) and turned into a set of Ruby modules (which are packaged with this release). Hi. I just finished packaging up rubygem-tzinfo, and I would appreciate a review so that I can get it into Fedora Extras. https://rubygems.org/gems/tzinfo (ver. 0.3.23 August 18, 2010 ) Packed for "rails 3.0.x in F15" in "Ruby SIG mailing list" http://lists.fedoraproject.org/pipermail/ruby-sig/2010-December/000376.html koji scratch build successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=2708055
Update to upstream release # 0.3.24 January 15, 2011 Spec URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo.spec SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo-0.3.24-1.fc14.src.rpm koji scratch build successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=2729534
Looks mostly good. The only comment I would say is if you could include a %check section and run 'rake test' in it. You will have to add a BuildRequies(check) for rubygem(rake) rpmlint looks good, koji looks good
To run the test suite, simply add the following to the spec %check pushd %{buildroot}%{geminstdir} rake test You will also need to add "BuildRequires: rubygem(rake)" Up to you though, this is not required for approval, and I've verified the test suite works against this rpm in any case. The package looks to be Fedora compliant overall minus one nit, please remove the "rm -rf %{buildroot}" in the %install section. APPROVED
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo.spec SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo-0.3.24-2.fc14.src.rpm koji scratch build successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=2729534 Test pass. (In reply to comment #3) > To run the test suite, simply add the following to the spec > > %check > pushd %{buildroot}%{geminstdir} > rake test > > You will also need to add "BuildRequires: rubygem(rake)" + Fixed. > The package looks to be Fedora compliant overall minus one nit, please remove > the "rm -rf %{buildroot}" in the %install section. + Fixed. > > APPROVED I am very thankful for collaboration.
New Package SCM Request ======================= Package Name: rubygem-tzinfo Short Description: Ruby library that uses the standard tz (Olson) database to provide daylight savings aware transformations between times in different time zones. Owners: minn Branches: InitialCC:
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo.spec SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo-0.3.24-2.fc14.src.rpm koji scratch build successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=2742209 Test pass. Comment 3 fixed.
Git done (by process-git-requests).
See that you push to rawhide and didn't request any other Fedora branches. Closing this out. Appreciate it.
New Package SCM Request ======================= Package Name: rubygem-tzinfo Short Description: Ruby library that uses the standard tz (Olson) database to provide daylight savings aware transformations between times in different time zones. Owners: minn Branches: f15 InitialCC:
(In reply to comment #9) > New Package SCM Request > ======================= > Package Name: rubygem-tzinfo > Short Description: Ruby library that uses the standard tz (Olson) database to > provide daylight savings aware transformations between times in different time > zones. > Owners: minn > Branches: f15 > InitialCC: Sorry. Not need.