Spec URL: http://sergiopr.fedorapeople.org/pgsphere.spec SRPM URL: http://sergiopr.fedorapeople.org/pgsphere-1.1.1-1.fc14.src.rpm Description: pgSphere is a server side module for PostgreSQL. It contains methods for working with spherical coordinates and objects. It also supports indexing of spherical objects.
- rpmlint checks return: pgsphere.src: W: file-size-mismatch pgsphere-1.1.1.tar.gz = 449970, http://pgfoundry.org/frs/download.php/2281/pgsphere-1.1.1.tar.gz = 449945 The size of the file in the package does not match the size indicated by peeking at its URL. Verify that the file in the package has the intended contents. Fix or document. Otherwise clean. OK package meets naming guidelines ?? package meets packaging guidelines The .sql file should be in %doc, not datadir. OK license ( ) OK, text in %doc, matches source OK spec file legible, in am. english ?? source matches upstream No, see above. OK on x86_64 package compiles on devel (x86) - no missing BR - no unnecessary BR OK no locales OK not relocatable OK owns all directories that it creates OK no duplicate files OK permissions ok OK %clean ok OK macro use consistent OK code, not content OK no need for -docs OK nothing in %doc affects runtime OK no need for .desktop file Mock build in progress to test BRs.
Mock build was good, BRs are as well. So it's just the file size mismatch and .sql file placement.
Hi, thanks for the review. I'm not sure that the sql file should be in docs. The file has to be loaded by postgresql to create the data types needed. There are quite a few sql files inside /usr/share already.
As long as it doesn't need customization by the installing admin, I suppose that's fine. So just the size mismatch, then.
-n %{name}-%{version} and the defattr line can be left out. sparse.c: GPL sparse.h: GPL
(In reply to comment #5) > -n %{name}-%{version} and the defattr line can be left out. > > sparse.c: GPL > sparse.h: GPL Good catch.
I have removed buildroot, %clean and %defattr sparse.c and .h have an exception in its license As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work under terms of your choice, so long as that work isn't itself a parser generator using the skeleton or a modified version thereof as a parser skeleton. Alternatively, if you modify or redistribute the parser skeleton itself, you may (at your option) remove this special exception, which will cause the skeleton and the resulting Bison output files to be licensed under the GNU General Public License without this special exception. So I think these files are also under the license of the main package. (Very good catch anyway) New files: http://guaix.fis.ucm.es/~spr/pgsphere.spec http://guaix.fis.ucm.es/~spr/pgsphere-1.1.1-2.fc15.src.rpm
Ok, everything looks good now, thanks. APPROVED.
New Package SCM Request ======================= Package Name: pgsphere Short Description: Spherical data types, functions and operators for PostgreSQL Owners: sergiopr Branches: F-15 F-14 InitialCC:
Git done (by process-git-requests).
Thanks everyone!