Need to get ipa-pki-theme built in koji. Summary: Certificate System - IPA PKI Theme Components spec file and src.rpm will be posted shortly.
SPEC URL: http://people.redhat.com/kwright/ipa-pki-theme/ipa-pki-theme.spec SRPM URL: http://people.redhat.com/kwright/ipa-pki-theme/ipa-pki-theme-9.0.0-1.fc13.src.rpm
Suggestions: 1)Please remove section wise comment style 2)Good to preserve timestamps using %{__make} install DESTDIR=%{buildroot} INSTALL="install -p" 3)If the packages you are obsoleting are not in Fedora and want to obsolete internal old versions with this package then mention it in SPEC file. 4) I think %description for main package should contain something like NOTE: written in SPEC.
Modified SPEC URL: http://mharmsen.fedorapeople.org/ipa-pki-theme.spec
Modified SRPM URL: http://mharmsen.fedorapeople.org/ipa-pki-theme-9.0.0-2.fc12.src.rpm
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2718643 APPROVED.
# cd pki/specs # svn diff ipa-pki-theme.spec Index: ipa-pki-theme.spec =================================================================== --- ipa-pki-theme.spec (revision 1729) +++ ipa-pki-theme.spec (working copy) @@ -1,10 +1,6 @@ -############################################################################### -### P A C K A G E H E A D E R ### -############################################################################### - Name: ipa-pki-theme Version: 9.0.0 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Certificate System - IPA PKI Theme Components URL: http://pki.fedoraproject.org/ License: GPLv2 @@ -23,69 +19,25 @@ %endif %global overview \ -================================== \ -|| ABOUT "CERTIFICATE SYSTEM" || \ -================================== \ - \ -Certificate System (CS) is an enterprise software system designed \ -to manage enterprise Public Key Infrastructure (PKI) deployments. \ - \ -The IPA PKI Suite is comprised of the following subsystems: \ - \ - * Certificate Authority (CA) \ - \ -Additionally, it provides javadocs on portions of the API, as well as \ -various command-line tools used to assist with an IPA deployment. \ - \ -To successfully deploy instances of a CA, \ -a Tomcat Web Server must be up and running locally on this machine. \ - \ -To meet the database storage requirements of each CA \ -instance, a 389 Directory Server must be up and running either locally \ -on this machine, or remotely over the attached network connection. \ - \ -IPA utilizes the 'pkicreate' utility to install a PKI subsystem, and \ -the 'pkisilent' utility to perform a batch configuration of this PKI \ -subsystem. \ - \ -After installation of this package, IPA utilizes the 'pkicreate' and \ -'pkiremove' utilities to respectively create and remove PKI instances. \ - \ -For deployment purposes, IPA PKI requires ALL of the subpackages \ -defined by the "pki-core" package. \ - \ +Several PKI packages require a "virtual" Theme component. These \ +"virtual" Theme components are "Provided" by various Theme "flavors" \ +including "dogtag", "redhat", and "ipa". Consequently, \ +all "dogtag", "redhat", and "ipa" Theme components MUST be \ +mutually exclusive! \ %{nil} %description %{overview} -############################################################################### -### S U B P A C K A G E H E A D E R S ### -############################################################################### - -############################## -## ipa-pki-common-theme ## -############################## - %package -n ipa-pki-common-theme Summary: Certificate System - PKI Common Framework User Interface Group: System Environment/Base -# NOTE: Several PKI packages require a "virtual" Theme component. These -# "virtual" Theme components are "Provided" by various Theme "flavors" -# including "dogtag", "redhat", and "ipa". Consequently, -# all "dogtag", "redhat", and "ipa" Theme components MUST be -# mutually exclusive! Conflicts: dogtag-pki-common-theme Conflicts: dogtag-pki-common-ui Conflicts: redhat-pki-common-theme Conflicts: redhat-pki-common-ui -Obsoletes: ipa-pki-common-theme < %{version}-%{release} -Obsoletes: ipa-pki-common-ui <= %{version} -Obsoletes: null-pki-common-theme <= %{version} -Obsoletes: null-pki-common-ui <= %{version} - Provides: pki-common-theme = %{version}-%{release} Provides: pki-common-ui = %{version}-%{release} @@ -98,29 +50,15 @@ %{overview} -############################## -## ipa-pki-ca-theme ## -############################## - %package -n ipa-pki-ca-theme Summary: Certificate System - Certificate Authority User Interface Group: System Environment/Base -# NOTE: Several PKI packages require a "virtual" Theme component. These -# "virtual" Theme components are "Provided" by various Theme "flavors" -# including "dogtag", "redhat", and "ipa". Consequently, -# all "dogtag", "redhat", and "ipa" Theme components MUST be -# mutually exclusive! Conflicts: dogtag-pki-ca-theme Conflicts: dogtag-pki-ca-ui Conflicts: redhat-pki-ca-theme Conflicts: redhat-pki-ca-ui -Obsoletes: ipa-pki-ca-theme < %{version}-%{release} -Obsoletes: ipa-pki-ca-ui <= %{version} -Obsoletes: null-pki-ca-theme <= %{version} -Obsoletes: null-pki-ca-ui <= %{version} - Provides: pki-ca-theme = %{version}-%{release} Provides: pki-ca-ui = %{version}-%{release} @@ -133,10 +71,6 @@ %{overview} -############################################################################### -### P A C K A G E P R O C E S S I N G ### -############################################################################### - %prep @@ -154,52 +88,12 @@ %{__make} VERBOSE=1 %{?_smp_mflags} -############################################################################### -### P A C K A G E I N S T A L L A T I O N ### -############################################################################### - %install %{__rm} -rf %{buildroot} cd build -%{__make} install DESTDIR=%{buildroot} +%{__make} install DESTDIR=%{buildroot} INSTALL="install -p" -############################################################################### -### S U B P A C K A G E I N S T A L L A T I O N ### -############################################################################### - -############################## -## ipa-pki-common-theme ## -############################## - - -############################## -## ipa-pki-ca-theme ## -############################## - - -############################################################################### -### P R E & P O S T I N S T A L L / U N I N S T A L L S C R I P T S ### -############################################################################### - -############################## -## ipa-pki-common-theme ## -############################## - - -############################## -## ipa-pki-ca-theme ## -############################## - - -############################################################################### -### I N V E N T O R Y O F F I L E S A N D D I R E C T O R I E S ### -############################################################################### - -############################## -## ipa-pki-common-theme ## -############################## - %files -n ipa-pki-common-theme %defattr(-,root,root,-) %doc dogtag/common-ui/LICENSE @@ -207,10 +101,6 @@ %{_datadir}/pki/common-ui/ -############################## -## ipa-pki-ca-theme ## -############################## - %files -n ipa-pki-ca-theme %defattr(-,root,root,-) %doc dogtag/ca-ui/LICENSE @@ -218,11 +108,14 @@ %{_datadir}/pki/ca-ui/ -############################################################################### -### C H A N G E L O G ### -############################################################################### - %changelog +* Thu Jan 13 2011 Matthew Harmsen <mharmsen> 9.0.0-2 +- Bugzilla Bug #668836 - Review Request: ipa-pki-theme +- Modified overview to pertain more to these packages +- Removed "Obsoletes:" lines (only pertinent to internal deployments) +- Modified installation section to preserve timestamps +- Removed sectional comments + * Wed Dec 1 2010 Matthew Harmsen <mharmsen> 9.0.0-1 - Initial revision. (kwright & mharmsen) # svn commit ipa-pki-theme.spec Sending ipa-pki-theme.spec Transmitting file data . Committed revision 1730.
New Package CVS Request ======================= Package Name: ipa-pki-theme Short Description: Certificate System - IPA PKI Theme Components Owners: kwright Branches: F-13, F-14, EL-5 InitialCC: ausil
Git done (by process-git-requests).
Can this review be closed now?
(In reply to comment #9) > Can this review be closed now? Yes
closing.