Bug 669790
| Summary: | Need a cleaner error message when uploading a package that already exists | ||
|---|---|---|---|
| Product: | [Retired] Pulp | Reporter: | Jay Dobies <jason.dobies> |
| Component: | z_other | Assignee: | Pradeep Kilambi <pkilambi> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Preethi Thomas <pthomas> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | unspecified | CC: | jconnor, jortel, skarmark |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | Sprint 20 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-16 12:07:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 647488 | ||
This was a request from rel_eng to give user a feedback as to if package exists and if so, what checksum it has, so they can validate and delete if if has a different checksum. I can make it read the message a bit cleaner: something like: Package [rh-cds-conf-0.17-1.noarch.rpm] already exists on the server with checksum ['5d7ae691e1cd764522a9e127cb81c3535c38eeee633838edc2175ffa52ff71fb'] of type ['sha256'] in repo [cloude]. As part of upload enhancements I added a verbose option which in my opinion should alleviate this concern:
$ sudo pulp-admin package upload --repoid=test17 *.rpm
* Starting Package Upload operation. See /var/log/pulp/client.log for more verbose output
* Performing Package Uploads to Pulp server
* Performing Repo Associations
* Package Upload complete.
$ sudo pulp-admin package upload --repoid=test17 *.rpm -v
* Starting Package Upload
* Performing Package Uploads to Pulp server
Package [ConsoleKit-debuginfo-0.4.1-3.el6.i686.rpm] already exists on the server with checksum [{u'sha256': u'3aab26ff8c6a8d031f29f7751669ed1f160558b6ec4bc63822bf417626b3ab8a'}]
Package [emoticons-0.1-1.x86_64.rpm] already exists on the server with checksum [{u'sha256': u'5898801b42427d31bb445edb2ddc84b8870f1bc83387f30367e9cc19d29c0351'}]
Package [Falcon-0.9.6.6-1.fc13.src.rpm] already exists on the server with checksum [{u'sha256': u'9f877157d0d8d319920376c9a3bee4b559cd35abf2825cff0dec358e935e2ef1'}]
Package [libgnomeui-debuginfo-2.24.1-3.1.el6.i686.rpm] already exists on the server with checksum [{u'sha256': u'732e00fe2c0dd43560fe72f3ce5978dc64aea8122f15f73dd06d36596f7f4acb'}]
Package [nautilus-dropbox-0.6.7-1.fedora.x86_64.rpm] already exists on the server with checksum [{u'sha256': u'bc431246a77d45a780d49f853bac99fb7da749a5cc179c3735c9146afc1d795f'}]
* Performing Repo Associations
Successfully associated following Packages to Repo [test17]:
libgnomeui-debuginfo-2.24.1-3.1.el6.i686.rpm
nautilus-dropbox-0.6.7-1.fedora.x86_64.rpm
Falcon-0.9.6.6-1.fc13.src.rpm
ConsoleKit-debuginfo-0.4.1-3.el6.i686.rpm
emoticons-0.1-1.x86_64.rpm
* Package Upload complete.
Fixed build: 0.138 verified [root@preethi upload]# rpm -q pulp pulp-0.0.146-1.fc14.noarch [root@preethi upload]# pulp-admin content upload -r upload --dir /root/upload/ --nosig * Starting Package Upload operation. See /var/log/pulp/client.log for more verbose output * Performing Package Uploads to Pulp server * Performing Repo Associations * Content Upload complete. [root@preethi upload]# pulp-admin content upload -r upload --dir /root/upload/ --nosig -v * Starting Package Upload * Performing Package Uploads to Pulp server Package [gofer-0.20-1.fc14.noarch.rpm] already exists on the server with checksum [1c284e102e46165fb368d7fe4fd1a1a32ddb5566a0a5486d67ef278d237d11e6] Package [grinder-0.0.85-1.fc14.noarch.rpm] already exists on the server with checksum [a65370e558b9743d3375156768509d9739750b820803ece0cf57d0a2b0518ed2] * Performing Repo Associations Package association Complete for Repo [upload]: Packages: grinder-0.0.85-1.fc14.noarch.rpm gofer-0.20-1.fc14.noarch.rpm Files: None * Content Upload complete. [root@preethi upload]# Closing with Community Release 15 pulp-0.0.223-4. Closing with Community Release 15 pulp-0.0.223-4. |
In the following example, I basically just ran the upload command twice. I think it's just clutter to display the sha256 to the user in these cases; simply indicating the package already exists is enough. $ pulp-admin repo upload --id cloude --dir /root/cloude-rpms Successful uploaded [httpd-2.2.3-40.el5.src.rpm] to repo [ cloude ] Package [rh-cds-conf-0.17-1.noarch.rpm] already exists on the server with checksum [{'sha256': '5d7ae691e1cd764522a9e127cb81c3535c38eeee633838edc2175ffa52ff71fb'}] in repo cloude