Hide Forgot
Spec URL: http://people.redhat.com/vondruch/rubygem-rsolr.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-rsolr-1.0.0-1.fc14.src.rpm Description: RSolr aims to provide a simple and extensible library for working with Solr Koji scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2726032
Hey just noticed a problem w/ this rpm when testing it out. The VERSION file shouldn't be marked as one of the files in the doc pkg as its needed by the solr runtime. Also, related, the sunspot rpm should contain the updated dependency to rsolr 1.0.0, it currently depends on rsolr ~> 0.12.1 which causes bundler to throw an error when run against this rpm. Thanks
Please see updated specs: Spec URL: http://people.redhat.com/vondruch/rubygem-rsolr.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-rsolr-1.0.0-2.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2740782 I will see what can I do about the sunspot.
I have fixed the sunspot and submitted required changes upstream: https://github.com/outoftime/sunspot/pull/27 So somebody can go ahead with review
I'm taking this one.
- The tests are compatible with RSpec 2, so I would recommend changing BR: rubygem(rspec) to rubygem(rspec-core). - Consider moving README.rdoc to doc subpackage. - The "%defattr(-, root, root, -)" lines can be omitted according to [1] So after you repair these few details, this package is APPROVED. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
Thank you for your review. I'll fix the issues before the commit. New Package SCM Request ======================= Package Name: rubygem-rsolr Short Description: A Ruby client for Apache Solr Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests).