Bug 670544 - consider moving default mount options to /etc/mke2fs.conf
Summary: consider moving default mount options to /etc/mke2fs.conf
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: e2fsprogs
Version: rawhide
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Eric Sandeen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-18 16:07 UTC by Oliver Henshaw
Modified: 2011-06-16 20:49 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-16 20:49:06 UTC
Type: ---


Attachments (Terms of Use)

Description Oliver Henshaw 2011-01-18 16:07:26 UTC
Description of problem:

/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py contains the line:

try:
    rc = iutil.execWithRedirect("tune2fs",
                                ["-c0", "-i0",
                                 "-ouser_xattr,acl", self.device],
                                stdout = "/dev/tty5",
                                stderr = "/dev/tty5")

The "-o" arguments control the default mount options of filesystems created by the installer, but a fs created by the installed system (e.g. by *parted or by system-config-lvm) will not have these same options. If they're good enough for anaconda, surely they're good enough to put in mke2fs.conf?

(Note that I'm ignoring the arguments which controll the fsck interval, these  are discussed in bug #649089 )


Version-Release number of selected component (if applicable):

anaconda-15.14-1.fc15.x86_64
e2fsprogs -1.41.14-1.fc15.x86_64


Additional info:

This seems to be similar to bug #120269 which, if bug 649089 comment #2 is any guide, pre-dates the introduction of mke2fs.conf by two years.

Comment 1 Chris Lumens 2011-01-18 16:28:51 UTC
I'll be happy to make that change once the config file has been updated to include those options.

Comment 3 Eric Sandeen 2011-03-09 20:52:27 UTC
From: Eric Sandeen <sandeen>
Date: Thu, 17 Feb 2011 21:56:17 +0000 (-0600)
Subject: e2fsprogs: enable user namespace xattrs by default
X-Git-Url: http://git.kernel.org/?p=fs%2Fext2%2Fe2fsprogs.git;a=commitdiff_plain;h=6a426c97ec2de0968b4cde62e5eab3df605bde33

e2fsprogs: enable user namespace xattrs by default

User namespace xattrs are generally useful, and I think extN
is the only filesystem requiring a special mount option to
enable them, when xattrs are otherwise available.  So this
change sets that mount option into the defaults, via a
mke2fs.conf option.

Note that if xattrs are config'd off, this will lead to a
mostly-harmless:

   EXT4-fs (sdc1): (no)user_xattr options not supported

message at mount time...

Signed-off-by: Eric Sandeen <sandeen>
Signed-off-by: Theodore Ts'o <tytso>
---

So - upstream they are default, and also settable in mke2fs.conf.  Which fedora got this yanked out of anaconda?  Does this need to be pushed into rawhide or can we wait for the (eventual) next e2fsprogs release?

Comment 4 Bill Nottingham 2011-03-09 20:56:58 UTC
It was only done in rawhide/F-16, so it can wait.

Comment 5 Eric Sandeen 2011-06-16 20:49:06 UTC
Ok, going to close this nextrelease.  Hopefully by F<next>, but e2fsprogs releases don't come too quickly these days.


Note You need to log in before you can comment on or make changes to this bug.