RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 671235 - cmdline_args doesn't return arguments after a NULL argument
Summary: cmdline_args doesn't return arguments after a NULL argument
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: systemtap
Version: 6.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Frank Ch. Eigler
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-20 19:57 UTC by Marc Milgram
Modified: 2011-12-06 15:17 UTC (History)
3 users (show)

Fixed In Version: systemtap-1.6-1.el6
Doc Type: Bug Fix
Doc Text:
Cause The cmdline_string() function used to concatenate commandline arguments would abort the concatenation when it encountered a NULL pointer for an argument. Consequence The cmdline_string() function would not print any arguments following a null argument. Fix The cmdline_string() function insert "" for empty string. Result The cmdline_args() function now prints all arguments from the command line including ones that follow a NULL argument.
Clone Of:
Environment:
Last Closed: 2011-12-06 15:17:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
cmdlinefail.stp (105 bytes, application/octet-stream)
2011-01-20 19:57 UTC, Marc Milgram
no flags Details
Proposed patch (682 bytes, patch)
2011-01-20 20:06 UTC, Marc Milgram
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1517 0 normal SHIPPED_LIVE systemtap bug fix and enhancement update 2011-12-06 00:50:46 UTC

Description Marc Milgram 2011-01-20 19:57:42 UTC
Created attachment 474525 [details]
cmdlinefail.stp

Description of problem:
In tapset context.stp, cmdline_args won't return data after the first NULL argument.

Version-Release number of selected component (if applicable):
systemtap-1.2-9.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
1. stap cmdlinefail.stp   (see attached file)
2. In a separate window, execute: /bin/ls "" additional arguments
3. Look at stap output
  
Actual results:
stap displays: /bin/ls

Expected results:
stap displays: /bin/ls ^@ additional arguments
Note, that instead of ^@, it could display something else, or even nothing, but it should display the additional arguments.

Additional info:

Comment 1 Marc Milgram 2011-01-20 20:06:07 UTC
Created attachment 474528 [details]
Proposed patch

I attached a suggested fix.

Comment 4 Frank Ch. Eigler 2011-06-10 19:07:42 UTC
upstream commit 5e3f644

Comment 8 William Cohen 2011-11-09 16:08:29 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    The cmdline_string() function used to concatenate commandline arguments
    would abort the concatenation when it encountered a NULL pointer for an
    argument.
Consequence
    The cmdline_string() function would not print any arguments following
    a null argument.
Fix
    The cmdline_string() function insert "" for empty string.
Result
    The cmdline_args() function now prints all arguments from the command
    line including ones that follow a NULL argument.

Comment 9 errata-xmlrpc 2011-12-06 15:17:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1517.html


Note You need to log in before you can comment on or make changes to this bug.