Bug 671267 - GFS2: allow gfs2 to update quota usage through quotactl
Summary: GFS2: allow gfs2 to update quota usage through quotactl
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Abhijith Das
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-20 22:18 UTC by Abhijith Das
Modified: 2011-05-19 12:42 UTC (History)
1 user (show)

Fixed In Version: kernel-2.6.32-112.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-19 12:42:24 UTC
Target Upstream Version:

Attachments (Terms of Use)
Patch to allow quota usage update through quotactl (1.60 KB, patch)
2011-01-20 22:18 UTC, Abhijith Das 		no flags Details | Diff
updated patch (2.37 KB, patch)
2011-01-24 07:01 UTC, Abhijith Das 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0542 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update 2011-05-19 11:58:07 UTC

Description Abhijith Das 2011-01-20 22:18:49 UTC 
Created attachment 474556 [details]
Patch to allow quota usage update through quotactl

Allow gfs2 to update quota usage through the quotactl syscall so that quotacheck can be performed through the userland quota tools.
Comment 1 RHEL Program Management 2011-01-20 22:30:23 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.
Comment 2 Abhijith Das 2011-01-20 22:31:48 UTC 
posted above patch to rhkernel-list for inclusion in RHEL6.1. I thought I had this patch posted for 6.1 already, turns out that's not the case :(. It's upstream though.
Comment 3 Abhijith Das 2011-01-24 07:01:53 UTC 
Created attachment 474899 [details]
updated patch

The only thing different is the addition of the following definitions to include/linux/dqblk_xfs.h. This was part of a series of updates to xfs-quota-related code upstream by Christoph. It didn't look to me that anything other than these symbols (FS_DQ_BCOUNT, in particular) were required for GFS2 quotacheck to operate correctly.

 /*
+ * Accounting values.  These can only be set for filesystem with
+ * non-transactional quotas that require quotacheck(8) in userspace.
+ */
+#define FS_DQ_BCOUNT           (1<<12)
+#define FS_DQ_ICOUNT           (1<<13)
+#define FS_DQ_RTBCOUNT         (1<<14)
+#define FS_DQ_ACCT_MASK                (FS_DQ_BCOUNT | FS_DQ_ICOUNT | FS_DQ_RTBCOUNT)
+

posted this patch to rhkernel-list for inclusion in rhel6.1
Comment 4 Aristeu Rozanski 2011-02-03 16:21:09 UTC 
Patch(es) available on kernel-2.6.32-112.el6
Comment 7 Nate Straz 2011-04-26 20:29:38 UTC 
Verified that we can set quotas using setquota which uses the quotactl() system call.
Comment 8 errata-xmlrpc 2011-05-19 12:42:24 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html
Note You need to log in before you can comment on or make changes to this bug.