Bug 671298 - kernel: acpi: debugfs: fix buffer overflows, double free
Summary: kernel: acpi: debugfs: fix buffer overflows, double free
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 671299
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-21 03:39 UTC by Eugene Teo (Security Response)
Modified: 2021-02-24 16:43 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-29 13:41:10 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Eugene Teo (Security Response) 2011-01-21 03:39:24 UTC 
File position is not controlled, it may lead to overwrites of arbitrary
kernel memory.  Also the code may kfree() the same pointer multiple
times.

http://lkml.org/lkml/2011/1/20/348

Acknowledgements:

Red Hat would like to thank Vasiliy Kulikov of Openwall for reporting this issue.
Comment 2 Eugene Teo (Security Response) 2011-01-21 03:46:13 UTC 
Introduced in a1a541d8 (v2.6.33-rc1).

*ppos cannot be controlled, but we need to make sure that the (1) buf is not accessed out of bounds, and (2) that *ppos + count will not wrap before copying a buffer from the userspace.
Comment 3 Eugene Teo (Security Response) 2011-01-21 03:49:24 UTC 
Statement:

The Linux kernel as shipped with Red Hat Enterprise Linux 4, 5, and 6 are not affected by this issue as they did not backport the upstream commit a1a541d8 that introduced the issue. A future kernel update in Red Hat Enterprise MRG may address this flaw.
Comment 4 John Kacur 2011-04-14 16:29:35 UTC 
commit 2949ad50711cc161721cf788711722eeeca33764 upstream
Note You need to log in before you can comment on or make changes to this bug.