Red Hat Bugzilla – Bug 67189
sawfish-1.9.0-2.src.rpm fails to build (7.3-everything upgrade to Milan beta-2)
Last modified: 2007-04-18 12:43:24 EDT
Description of Problem: SSIA. Performing a re-build of sawfish from the SRPM fails on an everything install of 7.3 then upgraded to Milan beta-2. The build gets an error on line 24 of the spec file (below). Version-Release number of selected component (if applicable): # ls -l sawfish-1.9.0-2.src.rpm -rw-r--r-- 1 root root 1478907 May 28 14:21 sawfish-1.9.0-2.src.rpm # md5sum sawfish-1.9.0-2.src.rpm ef2214dcfb3932b4c8492403a239dd17 sawfish-1.9.0-2.src.rpm How Reproducible: always (100%) Steps to Reproduce: 1. 7.3 "everything" install 2. Milan beta-2 "everything" install 3. rpm -Uvh {distdir}/SRPMS/sawfish-1.9.0-2.src.rpm 4. rpmbuild -ba /usr/src/redhat/SPECS/sawfish.spec Actual Results: The only line produced is as follows: error: line 24: Unknown tag: LANG=C
Seems to work for me with latest.
With a fresh Milan-re0717.nightly tree, I am getting the same LANG=C message as pointed out above. This is for sawfish-1.9.0-3.
1.9.0-5 has a random stab at a fix, but if it doesn't work I'd guess this is an RPM bug.
I take it back, the build system is horked so there's no 1.9.0-5 yet.
*** Bug 69305 has been marked as a duplicate of this bug. ***
#69305 argues it's an RPM issue. I think it's pretty obviously a change in RPM behavior, if nothing else.
It's because the spec file references %install in a comment instead of using %%install. The spec file parser always expands macros when it sees them and so %install gets expanded to a multiline bash script in a place where you can't just randomly expand bash.
I still see the same behavior with Limbo, except that the only single line now is reported with the error on line _26_ (used to be #24).
After editing the lines: ## If you add themes, be sure to add the tarball to the list ## down below in %install to: ## If you add themes, be sure to add the tarball to the list ## down below in %%install and recompiling sawfish.spec. You get the following error: RPM build errors: File not found: /var/tmp/sawfish-1.9.0-root/usr/libexec/rep/i386-redhat-linux-gnu/sawfish In the %files section of the spec file, the macro %_target_platform expands properly in the line --> %{_libexecdir}/sawfish/*/%{_target_platform} but does not expand properly in --> %{_libexecdir}/rep/%{_target_platform}/sawfish
fixed in 2.0-2 and later.
Fix confirmed with sawfish-2.0-4.