Bug 672234 – add POLLPRI to sock_def_readable()

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 672234 - add POLLPRI to sock_def_readable()

Summary:	add POLLPRI to sock_def_readable()

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	kernel (Show other bugs)
Sub Component:
Version:	6.0
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	Jiri Pirko
QA Contact:	Network QE
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2011-01-24 09:50 EST by Veaceslav Falico
Modified:	2015-05-04 21:22 EDT (History)
CC List:	8 users (show)

See Also:
Fixed In Version:	kernel-2.6.32-128.el6
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2011-05-23 16:38:37 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
reproducer source code (2.15 KB, text/plain) 2011-01-24 09:50 EST, Veaceslav Falico	no flags	Details
upstream patch fixed to apply cleanly (508 bytes, patch) 2011-01-24 09:51 EST, Veaceslav Falico	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2011:0542	normal	SHIPPED_LIVE	Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update	2011-05-19 07:58:07 EDT

Groups: None (edit)

Description Veaceslav Falico 2011-01-24 09:50:27 EST

Created attachment 474968 [details]
reproducer source code

The poll() could block forever on tcp sockets and Urgent data was received,
if the event flag only contains POLLPRI. This bug is introduced by commit
4938d7e0233 (poll: avoid extra wakeups in select/poll). Problem is that
TCP sockets use standard sock_def_readable() function for their
sk_data_ready() handler, and sock_def_readable() doesnt signal POLLPRI.

Only TCP is affected by the problem. Adding POLLPRI to the list of flags
might trigger unnecessary schedules, but URGENT handling is such a seldom used
feature this seems a good compromise.

Upstream commit: http://marc.info/?l=git-commits-head&m=129436629005347&w=2

Red Hat Enterprise Linux Version Number: RHEL6
Release Number: 6.0
Architecture: x86_64
Kernel Version: kernel-2.6.32-71.el6 


Step to Reproduce:

1. #gcc -o pollpri pollpri.c
2. #./pollpri


Actual Results:

After the message of "parent: waiting for child to exit" was printed by pollpri,
pollpri hanged up forever.

Expected Results:

The pollpri program can exit normally.

Attaching pollpri.c and line-fixed patch for rhel6 git.

Comment 1 Veaceslav Falico 2011-01-24 09:51:45 EST

Created attachment 474969 [details]
upstream patch fixed to apply cleanly

Comment 2 Neil Horman 2011-01-27 13:42:56 EST

Triage assignment.  If you feel this bug doesn't belong to you, or that it cannot be handled in a timely fashion, please contact me for re-assignment

Comment 4 RHEL Product and Program Management 2011-02-01 00:28:34 EST

This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 5 RHEL Product and Program Management 2011-03-01 18:20:03 EST

This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 8 Aristeu Rozanski 2011-03-30 10:31:37 EDT

Patch(es) available on kernel-2.6.32-128.el6

Comment 13 errata-xmlrpc 2011-05-23 16:38:37 EDT

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html

Note You need to log in before you can comment on or make changes to this bug.