Bug 672284 - Review Request: perl-Perl-Metrics-Simple - Count packages, subs, lines, etc. of many files
Summary: Review Request: perl-Perl-Metrics-Simple - Count packages, subs, lines, etc. ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 672246
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-24 17:34 UTC by Petr Pisar
Modified: 2011-01-26 09:12 UTC (History)
2 users (show)

Fixed In Version: perl-Perl-Metrics-Simple-0.15-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-26 09:12:03 UTC
Type: ---
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-01-24 17:34:53 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Metrics-Simple/perl-Perl-Metrics-Simple.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Metrics-Simple/perl-Perl-Metrics-Simple-0.15-1.fc14.src.rpm
Description:
Perl::Metrics::Simple provides just enough methods to run static analysis
of one or many Perl files and obtain a few metrics: packages, subroutines,
lines of code, and an approximation of cyclomatic (McCabe) complexity for
the subroutines and the "main" portion of the code.

Comment 1 Marcela Mašláňová 2011-01-25 08:48:23 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -q --provides perl-Perl-Metrics-Simple
perl(Perl::Metrics::Simple) = 0.15   
perl(Perl::Metrics::Simple::Analysis) = 0.15
perl(Perl::Metrics::Simple::Analysis::File) = 0.15
perl-Perl-Metrics-Simple = 0.15-1.fc15

rpm -q --requires perl-Perl-Metrics-Simple
perl(:MODULE_COMPAT_5.12.2)  
perl(File::Find) >= 1.01
perl(IO::File) >= 1.14
perl(PPI) >= 1.113
perl(Readonly) >= 1.03
perl(Readonly::XS) >= 1.02
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(VersionedDependencies) <= 3.0.3-1
perl >= 0:5.006
perl(Carp)  
perl(Data::Dumper)  
perl(English)  
perl(File::Basename)  
perl(Perl::Metrics::Simple)  
perl(Perl::Metrics::Simple::Analysis)  
perl(Perl::Metrics::Simple::Analysis::File)  
perl(Pod::Usage)  
perl(PPI::Document)  
perl(Statistics::Basic::Mean)  
perl(Statistics::Basic::Median)  
perl(Statistics::Basic::StdDev)  
perl(strict)  
perl(warnings)  
rpmlib(VersionedDependencies) <= 3.0.3-1
/usr/bin/perl  

It's required /usr/bin/perl and perl >= 0:5.006 but you can't probably do anythign about it.

ACCEPT (as soon as perl-Statistics-Basic will be in build root)

Comment 2 Petr Pisar 2011-01-25 09:08:10 UTC
New Package SCM Request
=======================
Package Name: perl-Perl-Metrics-Simple
Short Description: Count packages, subs, lines, etc. of many files
Owners: ppisar, mmaslano, psabata
Branches: 
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-01-25 15:09:21 UTC
This ticket is not assigned to anyone.  Please fix and re-raise the fedora-cvs
flag.

Comment 4 Petr Pisar 2011-01-25 15:18:03 UTC
Assigned to reviewer.

Comment 5 Jason Tibbitts 2011-01-25 23:42:49 UTC
Git done (by process-git-requests).

Comment 6 Petr Pisar 2011-01-26 09:12:03 UTC
Thank you for review and repository.


Note You need to log in before you can comment on or make changes to this bug.