Spec URL: http://kwizart.fedorapeople.org/review/openicc-data.spec SRPM URL: http://kwizart.fedorapeople.org/review/openicc-data-1.1.0-1.fc14.src.rpm Description: The Color Management Data (CMD) It may have an unsafe License status about PhotoGamutRGB_avg6c.icc according to default_profiles/base/COPYING: "Group C PhotoGamutRGB_avg6c.icc is licensed to be distributed freely. Modifications are not allowed." Blocking FE-Legal for that. But Kai-Uwe Behrmann may already have sent an email there.
Is there an update here?
http://lists.freedesktop.org/archives/openicc/2011q2/004130.html [ANNOUNCE] OpenICC Data package 1.2.0 ... The PhotoGamutRGB_avg6c.icc is completely removed to provide homogenous libpng/zlib licensing.
Okay, assuming that 1.2.0 gets packaged, I'm lifting FE-Legal.
Spec URL: http://kwizart.fedorapeople.org/review/openicc-data.spec SRPM URL: http://kwizart.fedorapeople.org/review/openicc-data-1.2.0-1.fc14.src.rpm Description: The Color Management Data (CMD) Changelog: - Update to 1.2.0
Some quick comments: defattr is no longer needed, you can remove it. Drop the README file, as it only contains instructions for installation. Drop buildroot, clean section and the rm -rf in the install section if you don't want to package for EPEL 4 or 5. Being that specific in the file list might cause you a lot of work on every update.
I might be interested to introduce EL branches at a later point. I prefer to remove the undeeded field later. Being specific will help to review new profiles introduction, specially as this may need a license check, so I prefer to keep
PS: I will update to drop the README on next friday because I'm not at home right now.
I wonder about the description and summary of the package: While that is what they put in README, the information on the website is very different. http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache You're installing files to %{_datadir}/icons. You therefore need the above scriptlet as well. The sample scripts use absolute paths for the binaries, but I don't know if that is a must.
(In reply to comment #8) > I wonder about the description and summary of the package: While that is what > they put in README, the information on the website is very different. The web site reflects the user group. The package, as a result of the collaboration in this group, has no own web site. > http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > > You're installing files to %{_datadir}/icons. You therefore need the above > scriptlet as well. The sample scripts use absolute paths for the binaries, but > I don't know if that is a must. Does icon cache update work on all XDG desktops likewise? I see the gtk name in the script.
Well, fine, but is the description you use what describes the package best? Ad Gnome: It's explained right above the the scriptlet.
SRPM: http://kwizart.fedorapeople.org/review/icc-profiles-openicc-1.3.0-1.fc14.src.rpm SPEC: http://kwizart.fedorapeople.org/review/icc-profiles-openicc.spec Summary: The OpenICC profiles Changelog: - Rename to icc-profiles-openicc - Add scriptlet for icons directory - Use absolute path for update-mime-database - Drop README - Add directory ownership
This package should be an easy review. Some comments ?
Sounds good to me, here is the rpmlint: icc-profiles-openicc.src: I: checking icc-profiles-openicc.src: I: checking-url http://www.freedesktop.org/wiki/OpenIcc (timeout 10 seconds) icc-profiles-openicc.src: I: checking-url http://downloads.sourceforge.net/project/openicc/OpenICC-Profiles/icc-profiles-openicc-1.3.0.tar.bz2 (timeout 10 seconds) icc-profiles-openicc.noarch: I: checking icc-profiles-openicc.noarch: I: checking-url http://www.freedesktop.org/wiki/OpenIcc (timeout 10 seconds) /home/tnorth/rpmbuild/SPECS/icc-profiles-openicc.spec: I: checking-url http://downloads.sourceforge.net/project/openicc/OpenICC-Profiles/icc-profiles-openicc-1.3.0.tar.bz2 (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. I can finalize the review if nobody takes it.
Thx Thibault, I will appreciate the review.
In comment#11, you wrote: "Summary: The OpenICC profiles", but the SPEC summary is still "The Color Management Data (CMD)". Also, the package %description must be updated for coherence. Besides, MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.OK MUST: The package must be named according to the Package Naming Guidelines OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. N/A MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. OK MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. N/A MUST: Packages must NOT bundle copies of system libraries. OK MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. N/A MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) OK MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). N/A MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. OK MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} N/A MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. OK MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. N/A MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. OK MUST: All filenames in rpm packages must be valid UTF-8. OK Therefore, the package is APPROVED
New Package SCM Request ======================= Package Name: icc-profiles-openicc Short Description: The OpenICC profiles Owners: kwizart Branches: f15 f16 el6 InitialCC:
Git done (by process-git-requests).