Bug 672811 - Review Request: perl-Perl-Critic-Compatibility - Perl::Critic policies for compatibility with Perl versions
Summary: Review Request: perl-Perl-Critic-Compatibility - Perl::Critic policies for co...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ruediger Landmann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 690569
TreeView+ depends on / blocked
 
Reported: 2011-01-26 14:02 UTC by Petr Pisar
Modified: 2011-03-24 17:10 UTC (History)
3 users (show)

Fixed In Version: perl-Perl-Critic-Compatibility-1.001-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-23 17:29:02 UTC
Type: ---
Embargoed:
rlandman: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-01-26 14:02:31 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Compatibility/perl-Perl-Critic-Compatibility.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Compatibility/perl-Perl-Critic-Compatibility-1.001-1.fc15.src.rpm
Description:
Some Perl::Critic policies that will help you keep your code compatible with
other versions of Perl, regardless of the version that you're developing with.
This includes both backward and forward compatibility.

Comment 1 Ruediger Landmann 2011-03-23 06:38:15 UTC
Thanks Petr; all good here.

APPROVED

 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [/] Rpmlint output is clean:
$ rpmlint SPECS/perl-Perl-Critic-Compatibility.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/perl-Perl-Critic-Compatibility-1.001-1.fc14.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint RPMS/noarch/perl-Perl-Critic-Compatibility-1.001-1.fc14.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Language specific
items
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [/] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [/] Spec file is legible and written in American English.
 [/] Sources used to build the package matches the upstream source, as provided
in the spec URL.
$ md5sum SOURCES/Perl-Critic-Compatibility-1.001.tar.gz 
30d38d6106380333d12159604281cd62  SOURCES/Perl-Critic-Compatibility-1.001.tar.gz
$ md5sum ~/Download/Perl-Critic-Compatibility-1.001.tar.gz 
30d38d6106380333d12159604281cd62  /home/rlandmann/Download/Perl-Critic-Compatibility-1.001.tar.gz

 [/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2935396
 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly (with the %find_lang macro)
 [-] ldconfig called in %post and %postun if required.
 [/] Package does not bundle copies of system libraries
 [/] Package is not relocatable.
 [/] Package must own all directories that it creates.
 [/] Package does not contain duplicates in %files.
 [/] Permissions on files are set properly
 [/] %files section includes a %defattr(...) line
 [/] Package consistently uses macros.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Development .so files in -devel subpackage, if present.
 [-] -devel packages require base package with full versioning.
 [/] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.
 [/] Filenames are valid UTF-8

Comment 2 Petr Pisar 2011-03-23 08:47:01 UTC
New Package SCM Request
=======================
Package Name: perl-Perl-Critic-Compatibility
Short Description: Perl::Critic policies for compatibility with Perl versions
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-03-23 14:26:12 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2011-03-23 17:29:02 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.