Hide Forgot
Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-PetPeeves-JTRAMMELL/perl-Perl-Critic-PetPeeves-JTRAMMELL.spec SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-PetPeeves-JTRAMMELL/perl-Perl-Critic-PetPeeves-JTRAMMELL-0.01-1.fc15.src.rpm Description: Module Perl::Critic::PetPeeves::JTRAMMELL provides policies that I want that haven't already been implemented elsewhere.
- rpmlint OK - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license OK - license field must match actual license OK - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build OK - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires OK - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK rpm -qp --provides ../RPMS/noarch/perl-Perl-Critic-PetPeeves-JTRAMMELL-0.01-1.fc14.noarch.rpm perl(Perl::Critic::PetPeeves::JTRAMMELL) = 0.01 perl(Perl::Critic::Policy::Variables::ProhibitUselessInitialization) = 0.01 perl-Perl-Critic-PetPeeves-JTRAMMELL = 0.01-1.fc14 rpm -qp --requires ../RPMS/noarch/perl-Perl-Critic-PetPeeves-JTRAMMELL-0.01-1.fc14.noarch.rpm perl(:MODULE_COMPAT_5.12.3) perl(Data::Dumper) perl(Perl::Critic::Policy) perl(Perl::Critic::Utils) perl(base) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 FPC didn't agree with core installation path (yet). I can't approve it.
And what am I supposed to do now? To change the path to different value that's not standardized too?
(In reply to comment #2) > And what am I supposed to do now? To install to vendordir, like any other perl module in RH and Fedora does.
Updated package published: Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-PetPeeves-JTRAMMELL/perl-Perl-Critic-PetPeeves-JTRAMMELL.spec SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-PetPeeves-JTRAMMELL/perl-Perl-Critic-PetPeeves-JTRAMMELL-0.01-1.fc16.src.rpm
Thank you, approved.
New Package SCM Request ======================= Package Name: perl-Perl-Critic-PetPeeves-JTRAMMELL Short Description: Policies to prohibit/require my pet peeves Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig
Git done (by process-git-requests).
Thank you for the review and the repository.