Fixing several problems reported by mfojtik from Red Hat. Thanks.

# rpmlint rubygem-net-ping-1.3.7-1.fc14.src.rpm
rubygem-net-ping.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

# rpmlint rubygem-net-ping-1.3.7-1.fc14.noarch.rpm 
rubygem-net-ping.noarch: I: enchant-dictionary-not-found en_US
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/TCP/ping%3f-i.yaml %3f
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/HTTP/ping%3f-i.yaml %3f
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/WMI/ping%3f-i.yaml %3f
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/UDP/service_check%3d-c.yaml %3d
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/ping%3f-i.yaml %3f
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/ICMP/ping%3f-i.yaml %3f
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/TCP/service_check%3d-c.yaml %3d
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/External/ping%3f-i.yaml %3f
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/UDP/data%3d-i.yaml %3d
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/ICMP/data_size%3d-i.yaml %3d
rubygem-net-ping.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/net-ping-1.3.7/ri/Net/Ping/UDP/ping%3f-i.yaml %3f
1 packages and 0 specfiles checked; 0 errors, 11 warnings.

Overwriting the original SPEC/SRPM files.

I am taking this one for review.

* New upstream version available
  - Please try to update to the latest version available upstream. 1.4 ATM.

* License
  - The code is release under Artistic 2.0 license
    https://github.com/djberg96/net-ping/blob/master/README#L41
  - Please update the license field accordingly:
      License: Artistic 2.0

* Unnecessary macros
  - The ruby_sitelib and ruby_sitearch macros are not in use in this package.
    Please remove them from top of the spec file.

* Splitting out document files
  - Please consider to create -doc subpackage and move the following
    files / directories into -doc
---------------------------------------------------
%doc %{geminstdir}/doc/ping.txt
%doc %{gemdir}/doc/%{gemname}-%{version}
%{geminstdir}/Rakefile
%{geminstdir}/test
%{geminstdir}/net-ping.gemspec
%{geminstdir}/MANIFEST
%{geminstdir}/CHANGES

%{gemdir}/doc/%{gemname}-%{version}
---------------------------------------------------

* Cleaning
  - "rm -rf %{buildroot}" at the top of %install is no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* Test
  - Please add build time test suite execution:
    BuildRequires: rubygem(test-unit)

    %check
    pushd %{buildroot}%{geminstdir}
    RUBYOPT="Ilib" testrb2 test/test_net_ping.rb
    popd

* Koji
  - Build looks fine
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2846629

* rpmlint
  - Everything OK.

Please also move examples into doc subpackage.

Also note that testing in mock environment, there will be probably necessary another build time requires, such as iputils, but also may be others.

Vito, thanks for the review. All your remarks were included. 

I also created a subpackage. And you were right - it needs iputils now :-)

Tests are failing on our koji due to blocked internet connectivity. Communicating with upstream about this. I will create a patch to disable these tests and upstream will possibly merge it.

I will push my changes next week.

Waiting for the upstream.

https://github.com/djberg96/net-ping/pull/3

Thank to the upstream I managed to have all unit tests working (using mock server) except three:

http://koji.fedoraproject.org/koji/getfile?taskID=2923113&name=build.log

I disabled these.

http://lzap.fedorapeople.org/fedora-packaging/rubygem-net-ping/1.4.1-1/

It builds in the Koji without any problems including unit tests.

http://koji.fedoraproject.org/koji/taskinfo?taskID=2923143

All remarks were also fixed.

* MUST: A package must own all directories that it creates.
  - Please add "%dir %{geminstdir}" at top of the files section to fulfill
    this requirement

Please fix the error mentioned above. Otherwise, the package looks good.

APPROVED

All done. Thank you.

New Package SCM Request
=======================
Package Name: rubygem-net-ping
Short Description: Net::Ping rubygem library
Owners: lzap
Branches: f15
InitialCC: ruby-sig

This ticket is not assigned to anyone; it should be assigned to the reviewer.
"ruby-sig" is not a valid user.

Please fix and re-raise the fedora-cvs flag.

New Package SCM Request
=======================
Package Name: rubygem-net-ping
Short Description: Net::Ping rubygem library
Owners: lzap
Branches: f15
InitialCC:

Git done (by process-git-requests).

The package is in the rawhide. I guess it can be closed.

Lets do it :)