Bug 674052 - rpmbuild 4.9.0-0.beta1 does not find some perl run time dependencies
Summary: rpmbuild 4.9.0-0.beta1 does not find some perl run time dependencies
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-generators
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 694496
TreeView+ depends on / blocked
 
Reported: 2011-01-31 13:39 UTC by Petr Pisar
Modified: 2017-08-08 11:39 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-08 11:39:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2011-01-31 13:39:24 UTC
New rpmbuild cannot find deeply required `perl(Data::Dumper)' module:

lib/Padre/Wx/ActionLibrary.pm:
   Padre::Wx::Action->new(
        name       => 'internal.dump_padre',
        label      => _T('Dump the Padre object to STDOUT'),
        comment    => _T('Dumps the complete Padre object to STDOUT for testing/debugging.'),
        menu_event => sub {
→           require Data::Dumper;
            open(


Cannot find perl(File::Copy) in lib/Padre/PluginManager.pm:
sub reset_my_plugin {
    [...]
    # Copy the My Plug-in
    unlink $dst;
→   require File::Copy;
    unless ( File::Copy::copy( $src, $dst ) ) {
        Carp::croak("Could not copy the My plug-in ($src) to $dst: $!");
    }
    chmod( 0644, $dst );
}


Cannot find perl(File::Find::Rule) in lib/Padre/Task/OpenResource.pm:
sub import {
    [...]
    # Find everything under Padre:: with a matching version,
    # which almost certainly means it is part of the main Padre release.
→   require File::Find::Rule;
    require Padre::Util;


and so on. The code is from perl-Padre I'm upgrading to version 0.80 now.

Is it a bug or a feature? These dependencies were found by previous rpmbuild.

Comment 1 Petr Pisar 2011-01-31 13:53:23 UTC
I'm sorry for disturbing, I used rpmdiff to compare the two packages and it reported as removed duplicate values.

So new rpmbuild is Ok.

Comment 2 Panu Matilainen 2011-01-31 13:57:38 UTC
Ack, thanks for letting me know. I was already scratching my head not being able to see such differences :)

Comment 3 Petr Pisar 2011-01-31 14:02:09 UTC
Actually, I injected the dependency manually into spec file. If I remove Requires: perl(Data::Dumper) from spec file, resulting binary package does not require it and rpmdiff shows two removal of it. So it does not work in the end.

Comment 4 Petr Pisar 2011-01-31 14:05:09 UTC
Actually, it did not work with previous version of rpmbuild too (I found I had it in the old spec file explicitly). So this is not regression. If you think it's not worth to solve it, just close this report as WANTFIX.

Comment 5 Panu Matilainen 2011-01-31 14:33:23 UTC
Ok. Right now dealing with regressions are the highest priority.

Missed dependencies would be nice to fix, but that's really a case of "patches cheerfully accepted" as it takes somebody who actually knows perl. Me, I'm totally clueless when it comes to perl.

Comment 6 Marcela Mašláňová 2011-03-29 16:12:47 UTC
Not requiring Data::Dumper is caused by perl.req, which didn't changed. This script doesn't take require statements. I've changed it locally, and I'll be testing if this part of script could be removed. 

@@ -177,13 +179,13 @@
          /x)
        ) {
       my ($whitespace, $statement, $module, $version) = ($1, $2, $3, $4);
-
+      #print "IF $statement, $module, $version\n";
       # we only consider require statements that are flushed against
       # the left edge. any other require statements give too many
       # false positives, as they are usually inside of an if statement
       # as a fallback module or a rarely used option
-
-      ($whitespace ne "" && $statement eq "require") && next;
+      # not false positives
+      #($whitespace ne "" && $statement eq "require") && next;
 
       # if there is some interpolation of variables just skip this
       # dependency, we do not want

Comment 7 Fedora Admin XMLRPC Client 2012-04-13 23:11:05 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 8 Fedora Admin XMLRPC Client 2012-04-13 23:13:26 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 9 Fedora End Of Life 2013-04-03 19:36:54 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 10 Panu Matilainen 2014-06-25 15:43:39 UTC
Reassigning to perl-generators now that there's a chance somebody might actually do something about this...

Comment 11 Jan Kurik 2015-07-15 15:17:20 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 12 Fedora End Of Life 2016-11-24 10:29:23 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 13 Petr Pisar 2016-11-24 10:43:51 UTC
"require" keywords not at the beginning of a line are ignored because they causes false positives (eval blocks). I don't know how many false positives and if it makes sense to stop ignoring them.

Comment 14 Fedora End Of Life 2017-07-25 18:28:45 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 15 Fedora End Of Life 2017-08-08 11:39:26 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.