Bug 674465 - Incorrect module bias on prelinked "find"
Summary: Incorrect module bias on prelinked "find"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: elfutils
Version: 14
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Roland McGrath
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-02 00:58 UTC by Josh Stone
Modified: 2011-04-12 21:26 UTC (History)
4 users (show)

Fixed In Version: elfutils-0.152-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-08 20:28:18 UTC


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Sourceware 12458 None None None Never

Description Josh Stone 2011-02-02 00:58:33 UTC
Description of problem:
The module bias returned by dwfl_module_getdwarf() is incorrect for a prelinked "/usr/bin/find", causing that app to segfault when probed by systemtap due to badly aligned breakpoint addresses.  Running "prelink -u /usr/bin/find" avoids the issue.

Version-Release number of selected component (if applicable):
elfutils-0.151-1.fc14.x86_64
findutils-4.5.9-2.fc14.x86_64
findutils-debuginfo-4.5.9-2.fc14.x86_64

How reproducible:
100%

Steps to Reproduce:
With "find" having prelink -u, and find.prelink being the original prelinked:

  $ eu-addr2line -e find 0x403ea0
  /usr/src/debug/findutils-4.5.9/find/ftsfind.c:648
  $ eu-addr2line -e find.prelink 0x403ea0
  /usr/src/debug/findutils-4.5.9/find/ftsfind.c:567

That address is main().  Prelink didn't move .text, so it should find the same source:line both times.

Comment 1 Roland McGrath 2011-02-02 03:09:44 UTC
Should be fixed upstream as of commit 3a44c9a (there are three consecutive commits that add up to the whole fix).

Comment 2 Roland McGrath 2011-02-02 03:16:51 UTC
For getting a test case, two issues were relevant here (finding three bugs, in fact).

First was that .interp changed address after prelink.  This was not correctly handled by libdwfl, though it didn't actually matter in this case.  libdwfl was failing to decode PT_INTERP from .gnu.prelink_undo at all for 64-bit files.  libdwfl was also using PT_INTERP from .gnu.prelink_undo when considering the prelinked file's sections, which was wrong--it had to consider the file's PT_INTERP as set by prelink to match it up with the .interp as moved by prelink.  Those issues all matter only for the purpose of excluding .interp from consideration as a synchronization address.  This would not come up unless .interp was the only PROGBITS/NOBITS section in the file, or the highest-addressed one.  Those are things that could happen in a valid ELF file, but will never happen in practice.

The second issue was that prelink split the .bss section into .dynbss and .bss, thus changing the sh_addr of .bss.  So, while the actual contents at the same addresses continued to match up, the sh_addr of .bss did not match up.  Since .bss was the highest-addressed PROGBITS/NOBITS section, it was chosen as the synchronization address and this was wrong.  The new code uses the highest sh_addr+sh_size (section ending address) instead.

Comment 3 Petr Muller 2011-02-02 21:37:43 UTC
I was trying to write a test for this, and 'prelink -u /usr/bin/find' does not fix things for me (still segfaults under systemtap). Am I doing something wrong here? 

I have the identical version of packages as in the initial comment, and I see the same outputs of eu-addr2line for both prelinked and un-prelinked binaries.

Comment 4 Roland McGrath 2011-02-02 21:44:50 UTC
You probably need to clear your ~/.systemtap/cache directory.  With the same script, stap will see that it was the same build ID for /usr/bin/find and reuse the module compiled the first time.

Comment 5 Josh Stone 2011-02-02 22:37:40 UTC
Actually, stap should still use a different cache id, as the file size will have changed.  That, and caching efforts don't come into play until pass-3/4, and it's in pass-2 it ought to (incorrectly) come up with the different module bias.

Do you by chance have /bin in your PATH before /usr/bin?  "find" exists in both places, the latter actually being a symlink.  Operating prelink on the symlink will separate the two, so actually we should probably operate everything on /bin/find instead.

Comment 6 Fedora Update System 2011-02-15 17:54:23 UTC
elfutils-0.152-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/elfutils-0.152-1.fc13

Comment 7 Fedora Update System 2011-02-15 17:56:36 UTC
elfutils-0.152-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/elfutils-0.152-1.fc14

Comment 8 Fedora Update System 2011-02-15 21:22:20 UTC
elfutils-0.152-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update elfutils'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/elfutils-0.152-1.fc14

Comment 9 Fedora Update System 2011-03-08 20:28:10 UTC
elfutils-0.152-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2011-04-12 21:26:54 UTC
elfutils-0.152-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.