Red Hat Bugzilla – Bug 67484
Wget segfaults when some URL specified twice
Last modified: 2008-05-01 11:38:02 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020408
Description of problem:
I wanted to download a part of www.finescale.com, so did wget with "-np" switch,
but since some images were out of that tree, I also specified them in
commandline separately. And wget segfaulted. I've narrowed the problem down,
and it turned out to be "URL duplication". (Yes, I made a mistake by specifying
that .gif twice, but wget shouldn't segfault anyway.)
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. wget -cdkrt0 -l0 -np http://www.finescale.com/fsm/images/RedReturn.gif
Actual Results: zsh: segmentation fault wget -cdkrt0 -l0 -np
Expected Results: There should be no segfault.
If the .gif is simply specified twice (RedReturn.gif RedReturn.gif), there's no
problem. But if these two instance are separated with another URL, the segfault
Happens with 1.8.2 as well... strage.
The problem is actually fairly simple -- a hash table is used without first
checking if it's non-NULL. You only see the problem if you specify a URL twice
*and* don't download a single HTML file. That's why the bug went unnoticed.
I'm about to attach a patch that fixes the problem.
Created attachment 66864 [details]
Patch that fixes the problem
Thanks, fixed in 1.8.2-3