Bug 675745 – GFS2: panics on quotacheck update

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 675745 - GFS2: panics on quotacheck update

Summary:	GFS2: panics on quotacheck update

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	kernel (Show other bugs)
Sub Component:
Version:	6.1
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	rc
Target Release:	---
Assigned To:	Abhijith Das
QA Contact:	Cluster QE
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2011-02-07 10:42 EST by Abhijith Das
Modified:	2011-05-19 08:42 EDT (History)
CC List:	2 users (show)

See Also:
Fixed In Version:	kernel-2.6.32-117.el6
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2011-05-19 08:42:26 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
small program to update quota using quotactl (2.52 KB, text/plain) 2011-02-07 10:51 EST, Abhijith Das	no flags	Details
another program to mimic operation of quotacheck utility (2.99 KB, text/plain) 2011-02-07 10:52 EST, Abhijith Das	no flags	Details
patch to fix the problem (816 bytes, patch) 2011-02-07 11:07 EST, Abhijith Das	no flags	Details \| Diff
Upstream version of the patch (873 bytes, patch) 2011-02-07 11:17 EST, Abhijith Das	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2011:0542	normal	SHIPPED_LIVE	Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update	2011-05-19 07:58:07 EDT

Groups: None (edit)

Description Abhijith Das 2011-02-07 10:42:41 EST

Description of problem:
When quotacheck attempts to update a gfs2 quota (that falls within block 0 of the quota file), a NULL-pointer dereference panic is triggered.

This is due to the fact that the gfs2 quota file is forcefully unstuffed in gfs2_adjust_quota(). But when quotacheck attempts the update, gfs2 concludes that no additional blocks need to be allocated as this is all in the first block of the file that's already allocated. However, the forceful unstuffing does need one block to be allocated and it panics because that block has not been allocated.

Also, there's another special case that needs handling. Some quotas lie on block boundaries and need to update two blocks instead of one. For such quotas, the block reservation for the transaction falls short of what is needed and an assert is tripped.

Comment 1 RHEL Product and Program Management 2011-02-07 10:50:46 EST

This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 2 Abhijith Das 2011-02-07 10:51:11 EST

Created attachment 477440 [details]
small program to update quota using quotactl

Comment 3 Abhijith Das 2011-02-07 10:52:03 EST

Created attachment 477441 [details]
another program to mimic operation of quotacheck utility

Comment 4 Abhijith Das 2011-02-07 11:07:13 EST

Created attachment 477444 [details]
patch to fix the problem

Comment 5 Abhijith Das 2011-02-07 11:17:25 EST

Created attachment 477451 [details]
Upstream version of the patch

Comment 6 Abhijith Das 2011-02-07 11:31:10 EST

Posted patch in comment #5 for inclusion upstream
Posted patch in comment #4 to rhkernel-list for inclusion in RHEL6.1

Comment 7 Aristeu Rozanski 2011-02-18 17:20:41 EST

Patch(es) available on kernel-2.6.32-117.el6

Comment 10 Nate Straz 2011-05-09 12:11:50 EDT

Verified with attached test programs against 2.6.32-131.0.10.el6.x86_64

Comment 11 errata-xmlrpc 2011-05-19 08:42:26 EDT

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html

Note You need to log in before you can comment on or make changes to this bug.