RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 675745 - GFS2: panics on quotacheck update
Summary: GFS2: panics on quotacheck update
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Abhijith Das
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-07 15:42 UTC by Abhijith Das
Modified: 2011-05-19 12:42 UTC (History)
2 users (show)

Fixed In Version: kernel-2.6.32-117.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-19 12:42:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
small program to update quota using quotactl (2.52 KB, text/plain)
2011-02-07 15:51 UTC, Abhijith Das
no flags Details
another program to mimic operation of quotacheck utility (2.99 KB, text/plain)
2011-02-07 15:52 UTC, Abhijith Das
no flags Details
patch to fix the problem (816 bytes, patch)
2011-02-07 16:07 UTC, Abhijith Das
no flags Details | Diff
Upstream version of the patch (873 bytes, patch)
2011-02-07 16:17 UTC, Abhijith Das
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0542 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update 2011-05-19 11:58:07 UTC

Description Abhijith Das 2011-02-07 15:42:41 UTC
Description of problem:
When quotacheck attempts to update a gfs2 quota (that falls within block 0 of the quota file), a NULL-pointer dereference panic is triggered.

This is due to the fact that the gfs2 quota file is forcefully unstuffed in gfs2_adjust_quota(). But when quotacheck attempts the update, gfs2 concludes that no additional blocks need to be allocated as this is all in the first block of the file that's already allocated. However, the forceful unstuffing does need one block to be allocated and it panics because that block has not been allocated.

Also, there's another special case that needs handling. Some quotas lie on block boundaries and need to update two blocks instead of one. For such quotas, the block reservation for the transaction falls short of what is needed and an assert is tripped.

Comment 1 RHEL Program Management 2011-02-07 15:50:46 UTC
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 2 Abhijith Das 2011-02-07 15:51:11 UTC
Created attachment 477440 [details]
small program to update quota using quotactl

Comment 3 Abhijith Das 2011-02-07 15:52:03 UTC
Created attachment 477441 [details]
another program to mimic operation of quotacheck utility

Comment 4 Abhijith Das 2011-02-07 16:07:13 UTC
Created attachment 477444 [details]
patch to fix the problem

Comment 5 Abhijith Das 2011-02-07 16:17:25 UTC
Created attachment 477451 [details]
Upstream version of the patch

Comment 6 Abhijith Das 2011-02-07 16:31:10 UTC
Posted patch in comment #5 for inclusion upstream
Posted patch in comment #4 to rhkernel-list for inclusion in RHEL6.1

Comment 7 Aristeu Rozanski 2011-02-18 22:20:41 UTC
Patch(es) available on kernel-2.6.32-117.el6

Comment 10 Nate Straz 2011-05-09 16:11:50 UTC
Verified with attached test programs against 2.6.32-131.0.10.el6.x86_64

Comment 11 errata-xmlrpc 2011-05-19 12:42:26 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html


Note You need to log in before you can comment on or make changes to this bug.