RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 676134 - [Cisco 6.1 Bug Fix] enic: Update enic driver to latest upstream version 2.1.1.10
Summary: [Cisco 6.1 Bug Fix] enic: Update enic driver to latest upstream version 2.1.1.10
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.1
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: rc
: 6.1
Assignee: Andy Gospodarek
QA Contact: Network QE
URL:
Whiteboard:
: 676705 (view as bug list)
Depends On:
Blocks: 676705 684865
TreeView+ depends on / blocked
 
Reported: 2011-02-08 22:02 UTC by roprabhu
Modified: 2014-06-29 23:03 UTC (History)
4 users (show)

Fixed In Version: kernel-2.6.32-128.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 676705 684865 695882 (view as bug list)
Environment:
Last Closed: 2011-05-19 12:00:05 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
update to upstream version 2.1.1.6 (23.15 KB, patch)
2011-02-15 17:41 UTC, Andy Gospodarek 		no flags Details | Diff
update to upstream version 2.1.1.10 (26.35 KB, patch)
2011-03-08 16:59 UTC, Andy Gospodarek 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0542 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update 2011-05-19 11:58:07 UTC

Description roprabhu 2011-02-08 22:02:17 UTC 
This bug fix updates enic version to 2.1.1.2:

git log:
f67224a5fb9249ea7c7e6282b7bed9117fd88a79 enic: Bug Fix: Dont reset
ENIC_SET_APPLIED flag on port profile disassociate

External link to patch:
http://marc.info/?l=linux-netdev&m=129557015920701&w=2
Comment 2 roprabhu 2011-02-10 05:04:13 UTC 
Andy, 

There are a few more patches (accepted upstream) which we dont think are critical but since you are picking some enic patches we were wondering if these can go in as well. 

0eb2602238e5aa33e0571a76aaf51a30bf32c3c2 enic: Clean up: Remove support for an older version of hardware
69161425800ac6cc28ac448bef5f21d09cb4f92a enic: Bug Fix: Reorder firmware devcmds - CMD_INIT and CMD_IG_VLAN_REWRITE_MODE
115d56f723c45088ddf46fac1ebba7c333039150 enic: Bug Fix: Fix return values of enic_add/del_station_addr routines
519874619f642afaf61530b0f4df3cd1e9a319e4 enic: Clean up: Organize devcmd wrapper routines

If you are ok taking these and need another bugzilla, I can create a new one. 

Thanks!.
Comment 3 Andy Gospodarek 2011-02-10 19:16:35 UTC 
Roopa, we can use the same bug for all of these changes.

I just needed a new bug for these since the old one already had changes committed for it.
Comment 4 RHEL Program Management 2011-02-10 19:30:21 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.
Comment 5 roprabhu 2011-02-10 21:03:19 UTC 
(In reply to comment #3)
> Roopa, we can use the same bug for all of these changes.
> 
> I just needed a new bug for these since the old one already had changes
> committed for it.


ok i filed a new one for  these: https://bugzilla.redhat.com/show_bug.cgi?id=676705

Thanks andy!
Comment 6 Andy Gospodarek 2011-02-15 15:19:29 UTC 
Roopa, was there a reason not to include this patch?

8a375557e303e4d082612bc3d79b23502a2a2a38 enic: Decouple mac address registration and deregistration from port profile set operation
Comment 7 roprabhu 2011-02-15 15:36:20 UTC 
Andy, we definitely need that one. I did not put that in here because in one of the comments you hinted you can put it along the below bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=641092

Or maybe i misunderstood. 

This is an imp patch...so please include it with which ever patch you think is reasonable.

Thanks!.
Comment 8 Andy Gospodarek 2011-02-15 17:41:40 UTC 
Created attachment 478936 [details]
update to upstream version 2.1.1.6

OK, initial testing looks good.  This is the patch I will propose on top of what we already have in RHEL6.
Comment 9 Andy Gospodarek 2011-02-15 17:46:04 UTC 
*** Bug 676705 has been marked as a duplicate of this bug. ***
Comment 10 Andy Gospodarek 2011-02-15 18:26:09 UTC 
Roopa, I closed 676705 as I didn't communicate clearly that this bug would be fine for all enic patches you have mentioned.

I changed the title of this bug indicating we will take all upstream changes that will take enic to version 2.1.1.6.
Comment 12 roprabhu 2011-02-15 19:15:03 UTC 
Thats perfect. Thanks Andy!.
Comment 13 Andy Gospodarek 2011-02-15 19:20:18 UTC 
(In reply to comment #12)
> Thats perfect. Thanks Andy!.

Glad to do it!

Thank you got letting me know quickly that there were beneficial fixes that we did not have.
Comment 14 roprabhu 2011-02-18 01:53:31 UTC 
Andy, Below are a few more small fixes committed today. They update enic driver to version 2.1.1.9. Let me know if you want me to open a new bugzilla. Thanks much.

1cbb1a61d59b7552e1e3fde485d8af5699fe16e0 enic: Always use single transmit and single receive hardware queues per device
5990b1892bbd0bb3adfc9a09bb3bcbde32471e59 enic: Clean up: Remove a not needed #ifdef
e0afe53fbea3823a1b1faef8d7701dd73bb74d5c enic: Bug fix: Reset driver count of registered unicast addresses to zero during devic
Comment 15 roprabhu 2011-02-27 22:28:05 UTC 
(In reply to comment #14)
> Andy, Below are a few more small fixes committed today. They update enic driver
> to version 2.1.1.9. Let me know if you want me to open a new bugzilla. Thanks
> much.
> 
> 1cbb1a61d59b7552e1e3fde485d8af5699fe16e0 enic: Always use single transmit and
> single receive hardware queues per device
> 5990b1892bbd0bb3adfc9a09bb3bcbde32471e59 enic: Clean up: Remove a not needed
> #ifdef
> e0afe53fbea3823a1b1faef8d7701dd73bb74d5c enic: Bug fix: Reset driver count of
> registered unicast addresses to zero during devic

Andy, Did you get a chance to pull the above ?. 
I have another one committed last week (Updates enic to 2.1.1.10):
"4d8340df77fa3e2d2d6f2bd287b6b20917a46a1e enic: Flush driver cache of registered addr lists during port profile disassociate"

Thanks,
Roopa
Comment 16 Andy Gospodarek 2011-03-03 22:02:40 UTC 
Roopa, I did post some patches, but did not include the ones in comment #14 or comment #15.  I can re-post my patch and consider adding them if you feel they are critical.
Comment 17 roprabhu 2011-03-03 22:30:41 UTC 
Andy, thanks for your response. Yes the patches are critical. Some of them the cleanup ones are probably not. But there is dependency between them..so its probably easier to pick them all.

Thanks.
Roopa
Comment 19 Andy Gospodarek 2011-03-08 16:59:44 UTC 
Created attachment 482956 [details]
update to upstream version 2.1.1.10

Roopa, this is the patch I proposed today for inclusion in RHEL6.1.  Thanks for letting us know about these additional fixes.
Comment 20 roprabhu 2011-03-08 17:55:47 UTC 
Thanks Andy. Looks great.
Comment 22 Aristeu Rozanski 2011-03-30 14:32:17 UTC 
Patch(es) available on kernel-2.6.32-128.el6
Comment 27 Jason Willeford 2011-05-09 16:48:08 UTC 
Hi Roopa ,
This bug needs to be partner verified.
Comment 28 roprabhu 2011-05-10 13:10:35 UTC 
Verified. 
Checked that all requested patches have made it to 2.6.32-131.0.5 (RHEL 6.1 snap5) kernel.
Comment 29 errata-xmlrpc 2011-05-19 12:00:05 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html
Note You need to log in before you can comment on or make changes to this bug.