Bug 676195 - [abrt] griffith-0.10-2.fc14: expression.py:1439:__nonzero__:TypeError: Boolean value of this clause is not defined
Summary: [abrt] griffith-0.10-2.fc14: expression.py:1439:__nonzero__:TypeError: Boolea...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: griffith
Version: 14
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Narasimhan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:3851924f
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-09 03:04 UTC by tonynalagan@gmail.com
Modified: 2011-03-31 20:05 UTC (History)
2 users (show)

Fixed In Version: griffith-0.12.1-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-31 16:58:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (979 bytes, text/plain)
2011-02-09 03:04 UTC, tonynalagan@gmail.com
no flags Details

Description tonynalagan@gmail.com 2011-02-09 03:04:39 UTC
abrt version: 1.1.14
architecture: x86_64
cmdline: python /usr/share/griffith/lib/griffith
component: griffith
executable: /usr/share/griffith/lib/griffith
kernel: 2.6.35.10-74.fc14.x86_64
package: griffith-0.10-2.fc14
reason: expression.py:1439:__nonzero__:TypeError: Boolean value of this clause is not defined
release: Fedora release 14 (Laughlin)
time: 1297218758
uid: 500

backtrace
-----
expression.py:1439:__nonzero__:TypeError: Boolean value of this clause is not defined

Traceback (most recent call last):
  File "/usr/share/griffith/lib/griffith", line 1168, in filter_txt
    quick_filter.change_filter(self)
  File "/usr/share/griffith/lib/quick_filter.py", line 46, in change_filter
    self.populate_treeview(statement)
  File "/usr/share/griffith/lib/griffith", line 1013, in populate_treeview
    main_treeview.populate(self, statement, where)
  File "/usr/share/griffith/lib/main_treeview.py", line 367, in populate
    if qf and not movies or isinstance(movies, Select): # if ".execute().fetchall()" not invoked on movies yet
  File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/expression.py", line 1439, in __nonzero__
    raise TypeError("Boolean value of this clause is not defined")
TypeError: Boolean value of this clause is not defined

Local variables in innermost frame:
self: <sqlalchemy.sql.expression.Select at 0x1f92b90; Select object>

How to reproduce
-----
1. Crashes intermittently when adding a video
2.
3.

Comment 1 tonynalagan@gmail.com 2011-02-09 03:04:41 UTC
Created attachment 477724 [details]
File: backtrace

Comment 2 Tony Nalagan 2011-03-10 19:15:24 UTC
The current FC14 package is based on old code. The current version of Griffith is version 0.12.1, and it does not produce the error. Fix is to repackage the FC14 release with the current code and push to updates. Until then install from source.

Comment 3 Fedora Admin XMLRPC Client 2011-03-11 13:59:05 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 4 Narasimhan 2011-03-20 09:00:02 UTC
This bug here has similar traceback.

https://bugs.launchpad.net/ubuntu/+source/griffith/+bug/662061 

This bug should be fixed in 0.12 and above.

I will update griffith to 0.12.1

Comment 5 Narasimhan 2011-03-23 13:03:48 UTC
I could reproduce it in Fedora 15 and griffith-0.10-3.fc15

expression.py:1439:__nonzero__:TypeError: Boolean value of this clause is not defined

Traceback (most recent call last):
  File "/usr/share/griffith/lib/griffith", line 266, in save_preferences
    save_preferences(self)
  File "/usr/share/griffith/lib/preferences.py", line 464, in save_preferences
    self.filter_txt(None)
  File "/usr/share/griffith/lib/griffith", line 1168, in filter_txt
    quick_filter.change_filter(self)
  File "/usr/share/griffith/lib/quick_filter.py", line 46, in change_filter
    self.populate_treeview(statement)
  File "/usr/share/griffith/lib/griffith", line 1013, in populate_treeview
    main_treeview.populate(self, statement, where)
  File "/usr/share/griffith/lib/main_treeview.py", line 367, in populate
    if qf and not movies or isinstance(movies, Select): # if ".execute().fetchall()" not invoked on movies yet
  File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/expression.py", line 1439, in __nonzero__
    raise TypeError("Boolean value of this clause is not defined")
TypeError: Boolean value of this clause is not defined

Local variables in innermost frame:
self: <sqlalchemy.sql.expression.Select at 0x20f6bd0; Select object>

After upgrading to v0.12.1, the same use case does not result in a crash reported in abrt and I don't get the trace in the console.

Comment 6 Fedora Update System 2011-03-23 13:49:48 UTC
griffith-0.12.1-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/griffith-0.12.1-1.fc15

Comment 7 Fedora Update System 2011-03-23 14:18:17 UTC
griffith-0.12.1-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/griffith-0.12.1-1.fc14

Comment 8 Christian Jann 2011-03-23 14:45:15 UTC
I don't know if I should open a new bug. I have installed http://kojipkgs.fedoraproject.org/packages/griffith/0.12.1/1.fc15/noarch/griffith-0.12.1-1.fc15.noarch.rpm on Fedora 15 and the app crashes on every start.

main_treeview.py:536:setmovie:TypeError: value is of the wrong type for this column



Traceback (most recent call last):

  File "/usr/share/griffith/lib/griffith", line 1466, in <module>

    griffith = Griffith(home_dir, config)

  File "/usr/share/griffith/lib/griffith", line 138, in __init__

    self.populate_treeview()

  File "/usr/share/griffith/lib/griffith", line 982, in populate_treeview

    main_treeview.populate(self, statement, where)

  File "/usr/share/griffith/lib/main_treeview.py", line 490, in populate

    addmovie(self, movie)

  File "/usr/share/griffith/lib/main_treeview.py", line 506, in addmovie

    setmovie(self, movie, myiter)

  File "/usr/share/griffith/lib/main_treeview.py", line 536, in setmovie

    treemodel.set_value(iter, 7, movie.year)

TypeError: value is of the wrong type for this column



Local variables in innermost frame:

movie: (378, u'13th Warrior, The', u'Der 13te Krieger', u'John McTiernan , Michael Crichton', u'9d44510b183875e59ea7d5340846c4b7', u'Action\n, Abenteuer\n, Fantasy', True, 1999, 100, 6, None, None)

self: <__main__.Griffith object at 0x17ce110>

pixbuf: <gtk.gdk.Pixbuf object at 0x285ca50 (GdkPixbuf at 0x2f740a0)>

iter: <GtkTreeIter at 0x2f7fba0>

filename: u'/home/chris/.griffith/posters/9d44510b183875e59ea7d5340846c4b7_s.jpg'

treemodel: <gtk.TreeStore object at 0x30c4960 (GtkTreeStore at 0x2fb8dc0)>


---------------
movie: (378, u'13th Warrior, The', u'Der 13te Krieger', u'John McTiernan , Michael Crichton', 
This movie was the third film in the database but now is the first (with first I mean the movie which is selected when starting the app), I've copied .griffith from Fedora 14 to Fedora 15 and started griffith but It has crashed, than I've opened a backup of the database again on F14, deleted the first, than the second film but griffith on F15 still crashes when loading the first film.

Comment 9 Narasimhan 2011-03-23 15:19:46 UTC
Thanks for reporting this.

Yes, this defect has been reported in griffith's defect tracking system.

https://bugs.launchpad.net/griffith/+bug/702495 and fixed in 0.13.

I am not sure whether to revoke this update since you have found that griffith has not been usable in Fedora 15. I myself tried by installing the older griffith and then moving to the new version. But I didn't add any movie data.

I can try applying a patch from the commit. If you could test that and let me know if there isn't any issue then I can submit a bugfix update.

Comment 10 Narasimhan 2011-03-23 15:54:35 UTC
Hi  Christian,
Can you file a new defect for the crash you noticed with the 0.12.1 update? I have a patch handy and would provide it as a new update (revoke the existing one).

Comment 11 Narasimhan 2011-03-23 16:06:15 UTC
Hi Christian,

New build here. 
http://narasim.fedorapeople.org/griffith-0.12.1-2.fc14.noarch.rpm

It would be good if you can test it and let me know whether the new issue is fixed.

Comment 12 Christian Jann 2011-03-23 16:21:11 UTC
Everything is working now, no crashes, searching works and I can add a new film. I've actually installed the F14 package on F15 but it is working fine.
A big thanks to you!

Comment 13 Narasimhan 2011-03-23 16:33:13 UTC
Hi,
Thanks for testing. I have created a new bug for this problem at bug 690232

Also in the enhancement update , can you provide negative karma?
https://admin.fedoraproject.org/updates/griffith-0.12.1-1.fc15

Comment 14 Fedora Update System 2011-03-23 17:28:40 UTC
griffith-0.12.1-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/griffith-0.12.1-2.fc14

Comment 15 Fedora Update System 2011-03-23 17:28:51 UTC
griffith-0.12.1-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/griffith-0.12.1-2.fc15

Comment 16 Fedora Update System 2011-03-31 16:57:52 UTC
griffith-0.12.1-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2011-03-31 20:04:55 UTC
griffith-0.12.1-2.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.