RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 676374 - cannot set spice's passwdValidTo
Summary: cannot set spice's passwdValidTo
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Michal Privoznik
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-09 16:51 UTC by Dan Kenigsberg
Modified: 2011-05-19 13:26 UTC (History)
10 users (show)

Fixed In Version: libvirt-0.8.7-6.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-19 13:26:54 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0596 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2011-05-18 17:56:36 UTC

Description Dan Kenigsberg 2011-02-09 16:51:07 UTC 
Description of problem:
virsh update-device domname <(echo '<graphics autoport="yes" listen="0" passwd="xxx" port="5900" tlsPort="-1" type="spice" passwdValidTo="2011-02-10T08:42:32" />')
fails with 
error: internal error cannot change port settings on spice graphics

Version-Release number of selected component (if applicable):
libvirt-0.8.7-5.el6.x86_64

How reproducible:
always

Additional info:
(06:33:47 PM) danpb: danken: ahhhh
(06:34:04 PM) danpb:     } else if (def->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {
(06:34:04 PM) danpb:   ....
(06:34:04 PM) danpb:         def->data.spice.listenAddr = virXMLPropString(node, "listen");
(06:34:04 PM) danpb:         def->data.spice.keymap = virXMLPropString(node, "keymap");
(06:34:04 PM) danpb:         if (virDomainGraphicsAuthDefParseXML(node, &def->data.vnc.auth) < 0)
(06:34:04 PM) mkarg is now known as mkarg|afk
(06:34:05 PM) danpb:             goto error;
(06:34:09 PM) danpb: spot the typo there !
(06:34:30 PM) danpb: between 0.8.7-3 and -5 we added another field into def->data.vnc 
(06:34:38 PM) danpb: so this previously harmless typo is now a real bug
(06:34:48 PM) danpb: danken: file a bz for it please & mark it regression
Comment 3 Michal Privoznik 2011-02-10 11:09:20 UTC 
patch commited to upstream:

commit 10713b1b98268a6eb05ba0912c1f4643c25f2564
Author: Michal Privoznik <mprivozn>
Date:   Thu Feb 10 10:50:10 2011 +0000

    Fix typo in parsing of spice 'auth' data
    
    A typo s/spice/vnc/ caused parsing of the spice 'auth' data
    to write into the wrong part of the struct, blowing away
    other unrelated data.
    
    * src/conf/domain_conf.c: s/vnc/spice/ in parsing spice auth
Comment 5 Min Zhan 2011-02-12 11:57:39 UTC 
Verified as Passed in below environment:
# uname -a
Linux dhcp-65-85.nay.redhat.com 2.6.32-112.el6.x86_64 #1 SMP Wed Feb 2 14:17:15
EST 2011 x86_64 x86_64 x86_64 GNU/Linux
kernel-2.6.32-112.el6.x86_64
qemu-kvm-0.12.1.2-2.132.el6.x86_64
libvirt-0.8.7-6.el6.x86_64


Steps:
1. Prepare a guest with graphics as following:
   <graphics type='spice' port='5905' tlsPort='-1' autoport='no' listen='0.0.0.0' keymap='en-us'/>

2. Start the guest
# virsh start rhel6
Domain rhel6 started

Use spice-client to check guest windows
# /usr/libexec/spicec -h 0.0.0.0 -p 5905

3. Prepare a xml as following
# cat passwd.xml 
<graphics type='spice' port='5905' autoport='no' keymap='en-us'  passwd='hello' tlsPort='-1' listen='0.0.0.0' passwdValidTo='2011-02-12T20:10:00'/>

4.Change spice password on the fly for the guest.
# virsh update-device rhel6 passwd.xml 
Device updated successfully

Connect guest windows again
# /usr/libexec/spicec -h 0.0.0.0 -p 5905 -w hello

# virsh dumpxml rhel6
...
 <graphics type='spice' port='5905' tlsPort='-1' autoport='no' listen='0.0.0.0' keymap='en-us' passwdValidTo='2011-02-12T20:10:00'/>
...
Comment 8 Michal Privoznik 2011-05-04 08:40:51 UTC 
* The problem was typo in source code resulting accessing uninitialized union and thus crash

* setting auth against spice caused libvirt to print error message

* The typo was fixed

* So setting auth works well
Comment 9 errata-xmlrpc 2011-05-19 13:26:54 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0596.html
Note You need to log in before you can comment on or make changes to this bug.